8000 Migrated UserSessionLimitsTest and UserSessionLimitsUtils by msdaly200 · Pull Request #48187 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Migrated UserSessionLimitsTest and UserSessionLimitsUtils - #48187

Merged
mposolda merged 5 commits into
keycloak:mainfrom
msdaly200:48170
Apr 24, 2026
Merged

Migrated UserSessionLimitsTest and UserSessionLimitsUtils#48187
mposolda merged 5 commits into
keycloak:mainfrom
msdaly200:48170

Conversation

@msdaly200
@msdaly200 msdaly200 commented Apr 17, 2026
Copy link
Copy Markdown
Contributor

Closes #48170.

Migrated UserSessionLimitsTest and UserSessionLimitsUtils files from Arquillian to new test framework.
Minor debug change to UserSessionLimitsAuthenticator.

@msdaly200
msdaly200 requested review from a team as code owners April 17, 2026 10:20
@keycloak-github-bot
keycloak-github-bot Bot commented Apr 17, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesMetadataTest

Keycloak CI - Adapter IT Strict Cookies

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest.assertForbiddenLogin(SAMLServletAdapterTest.java:558)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 17, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

7438
@msdaly200
msdaly200 force-pushed the 48170 branch 2 times, most recently from 52586f8 to 0e406aa Compare April 20, 2026 12:14
@vaceksimon
vaceksimon self-requested a review April 21, 2026 07:10
rmartinc
rmartinc requested changes Apr 21, 2026
View reviewed changes
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @msdaly200 for the PR!

Just a few nitpicks for you to consider.

Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsUtil.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
vaceksimon
vaceksimon suggested changes Apr 21, 2026
View reviewed changes
@vaceksimon vaceksimon left a comment •
edited
Loading
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identified a couple of areas for improvement. This is a pretty long class, kudos Marie

Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsUtil.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
@msdaly200
msdaly200 requested a review from a team as a code owner April 21, 2026 16:10
@msdaly200
msdaly200 force-pushed the 48170 branch 2 times, most recently from e285dd5 to f1d6f98 Compare April 22, 2026 09:04
@msdaly200
msdaly200 requested a review from a team as a code owner April 22, 2026 09:04
@msdaly200
msdaly200 force-pushed the 48170 branch 3 times, most recently from 1f5efa4 to ae3084c Compare April 22, 2026 09:16
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 22, 2026
Closed
@msdaly200
msdaly200 force-pushed the 48170 branch 2 times, most recently from 6784360 to 8728897 Compare April 23, 2026 08:56
@msdaly200
msdaly200 force-pushed the 48170 branch 2 times, most recently from 94e28b7 to 429b31c Compare April 23, 2026 09:10
rmartinc
rmartinc requested changes Apr 23, 2026
View reviewed changes
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick more and for me the PR is ready. Don't know if @vaceksimon is OK too.

Comment thread tests/base/src/test/java/org/keycloak/tests/sessionlimits/UserSessionLimitsTest.java Resolved
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 23, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 23, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.authz.PolicyEvaluationTest#

Keycloak CI - Base IT (3)

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

Report flaky test

rmartinc
rmartinc approved these changes Apr 24, 2026
View reviewed changes
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @msdaly200! LGTM! Let's see if @vaceksimon is OK.

vaceksimon
vaceksimon approved these changes Apr 24, 2026
View reviewed changes
@vaceksimon vaceksimon left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @msdaly200 !

@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 24, 2026
Closed
@msdaly200
Closes keycloak#48170: Migrate UserSessionLimitsTest to new test fram…
6e3e0a2 
…ework

Signed-off-by: Marie Daly <marie.daly1@ibm.com>
@msdaly200
Closes keycloak#48170, update after merge
a23df39 
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
@msdaly200
Closes keycloak#48170, updated following review
18ec32d 
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
@msdaly200
Closes keycloak#48170, resolve spotless issue
e6e74e1 
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
@msdaly200
Closes keycloak#48170, remove keycloakUrls
217cec8 
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
mposolda
mposolda approved these changes Apr 24, 2026
View reviewed changes
@mposolda mposolda left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging on behalf of @rmartinc and @vaceksimon reviews.

@mposolda
mposolda merged commit 766a872 into keycloak:main Apr 24, 2026
85 checks passed
D03B
@msdaly200
msdaly200 deleted the 48170 branch April 30, 2026 10:10
@stianst stianst mentioned this pull request Jun 1, 2026
Closed
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@msdaly200 @sashyo
Migrated UserSessionLimitsTest and UserSessionLimitsUtils (keycloak#…
277b815 
…48187)

Closes keycloak#48170


Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes
@rmartinc rmartinc rmartinc approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@vaceksimon vaceksimon vaceksimon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate tests for UserSessionLimitsTest

4 participants

@msdaly200 @mposolda @rmartinc @vaceksimon
0