8000 Remove legacy Client API V2 service by mabartos · Pull Request #48091 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Remove legacy Client API V2 service - #48091

Merged
vmuzikar merged 3 commits into
keycloak:mainfrom
mabartos:KC-47426
Apr 21, 2026
Merged

Remove legacy Client API V2 service#48091
vmuzikar merged 3 commits into
keycloak:mainfrom
mabartos:KC-47426

Conversation

@mabartos
@mabartos mabartos commented Apr 15, 2026 •
edited
Loading
Copy link
Copy Markdown
Member

@mabartos mabartos self-assigned this Apr 15, 2026
This was referenced Apr 15, 2026
Closed
Closed
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 15, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 15, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.UserSessionProviderModelTest#testCreateUserSessionsParallel

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (RUNNABLE):
	at java.management@25.0.2/sun.management.ThreadImpl.dumpThreads0(Native Method)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:505)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:493)
...

Report flaky test

org.keycloak.testsuite.model.session.UserSessionProviderModelTest#testCreateUserSessionsParallel

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (RUNNABLE):
	at java.management@25.0.2/sun.management.ThreadImpl.dumpThreads0(Native Method)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:505)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:493)
...

Report flaky test

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 15, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.UserSessionProviderModelTest#testStreamsMarshalling

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (RUNNABLE):
	at java.management@25.0.2/sun.management.ThreadImpl.dumpThreads0(Native Method)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:505)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:493)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 15, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 15, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

keycloak-github-bot Bot commented Apr 15, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.UserSessionProviderModelTest#testStreamsMarshalling

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (RUNNABLE):
	at java.management@25.0.2/sun.management.ThreadImpl.dumpThreads0(Native Method)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:505)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:493)
...

Report flaky test

@mabartos
mabartos marked this pull request as ready for review April 15, 2026 15:33
@mabartos
mabartos requested review from a team as code owners April 15, 2026 15:33
@vmuzikar
vmuzikar commented Apr 16, 2026
Copy link
Copy Markdown
Contributor

Now that #47874 was merged, can you please rebase, @mabartos?

@mabartos
mabartos force-pushed the KC-47426 branch 2 times, most recently from 5e9bd76 to 991a0b9 Compare April 17, 2026 12:34
This was referenced Apr 17, 2026
Closed
Closed
vmuzikar
vmuzikar requested changes Apr 17, 2026
View reviewed changes
Comment thread rest/admin-v2/services/src/main/java/org/keycloak/rest/admin/api/client/DefaultClientsApi.java
@@ -16,7 +16,7 @@
import org.keycloak.models.RealmModel;
import org.keycloak.representations.admin.v2.BaseClientRepresentation;
import org.keycloak.services.client.ClientService;
import org.keycloak.services.client.ClientServiceHelper;
@vmuzikar vmuzikar Apr 17, 2026
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove ClientServiceHelper as well?

@mabartos mabartos Apr 20, 2026
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread rest/admin-v2/services/src/main/java/org/keycloak/services/client/DefaultClientService.java Resolved
@mabartos
mabartos commented Apr 17, 2026
Copy link
Copy Markdown
Member Author

@vmuzikar Ooops, seems like it was caused by the rebase. I'll update it; nice catch!

@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 17, 2026
Closed
@mabartos
mabartos requested a review from vmuzikar April 20, 2026 08:37
shawkins
shawkins previously approved these changes Apr 20, 2026
View reviewed changes
@shawkins shawkins left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vmuzikar
vmuzikar previously approved these changes Apr 21, 2026
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@vmuzikar
vmuzikar commented Apr 21, 2026
Copy link
Copy Markdown
Contributor

@mabartos Can you please resolve conflicts?

mabartos added 3 commits April 21, 2026 11:18
@mabartos
Remove legacy Client API V2 service
c992025 
Closes keycloak#47426

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
Remove workarounds for Operator
a44b25d 
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
Fix compilation errors
0181da5 
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
mabartos dismissed stale reviews from vmuzikar and shawkins via 0181da5 April 21, 2026 09:21
@mabartos
mabartos commented Apr 21, 2026
Copy link
Copy Markdown
Member Author

@vmuzikar Done.

The conflicting part was this, and it's resolved:

This was referenced Apr 21, 2026
Closed
Closed
@mabartos
mabartos requested a review from vmuzikar April 21, 2026 11:15
@vmuzikar
vmuzikar merged commit e299bb6 into keycloak:main Apr 21, 2026
90 checks passed
@mabartos mabartos mentioned this pull request Apr 27, 2026
Merged
@stianst stianst mentioned this pull request Jun 1, 2026
Closed
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@mabartos @sashyo
Remove legacy Client API V2 service (keycloak#48091)
6b2a2e0 
* Remove legacy Client API V2 service

Closes keycloak#47426

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

* Remove workarounds for Operator

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

* Fix compilation errors

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

---------

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
@shawkins shawkins shawkins left review comments
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mabartos mabartos

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove default client v2 service

3 participants

@mabartos @vmuzikar @shawkins
0