Repository navigation
when the realm session limit is exceeded and behavior is set to Termi… - #48064
Merged
Merged
Conversation
Member
|
@martinkrcka - please add a sign-off to your commit as outlined in the CONTRIBUTING.md file. |
Contributor
Author
Done :-) |
Member
|
@martinkrcka Still not done :/ The commit needs to contain the "Signed-off-by: xxx"... you can add the |
Contributor
Author
Finally it should be done! |
Member
|
@martinkrcka Thanks! As this PR is clearly built on top of @mateenali66's PR, you should add this note to the commit description: As I think this approach with |
Member
|
@martinkrcka It'd be also good to return-fast, when the count is 0, so similar to what @mateenali66 did here: if (numberOfSessionsThatNeedToBeLoggedOut == 0) {
logger.debug("No additional sessions that need to be logged out");
return Collections.emptyList();
} |
…nate oldest session, the authenticator calls handleLimitExceeded(userSessionsForClient, userClientLimit) first. if the user has fewer existing sessions for the current client than userClientLimit - 1, getNumberOfSessionsThatNeedToBeLoggedOut() returns a negative value and Stream.limit(negative) throws IllegalArgumentException, producing a 500 on every login to that client. This change ensures that getNumberOfSessionsThatNeedToBeLoggedOut returns 0 if the calculated value is negative. The dependent execution steps remain unchanged. A result of 0 sessions to be purged from the current client triggers the removal of the oldest sessions across all clients. also added a regression test in UserSessionLimitsTest that reproduces the scenario: realm limit=2, client limit=3, two logins on client-a to saturate the realm, then login on client-b (0 existing client sessions). Fixes keycloak#48040 Co-authored-by: Mateen Anjum <mateenali66@gmail.com> Signed-off-by: Martin Krcka <martin.krcka@adesso.de>
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
mabartos
approved these changes
Apr 15, 2026
Member
There was a problem hiding this comment.
@martinkrcka I've added the last missing piece.
@martinkrcka @mateenali66 Thanks for the contribution!
@keycloak/core-authn Anyone want to review it as well?
rmartinc
approved these changes
Apr 15, 2026
Contributor
There was a problem hiding this comment.
Thanks @martinkrcka and @mabartos! LGTM too!
ahus1
approved these changes
Apr 15, 2026
Member
There was a problem hiding this comment.
Approving based on previous reviews.
mabartos
added a commit
to mabartos/keycloak
that referenced
this pull request
Apr 15, 2026
keycloak#48064) * when the realm session limit is exceeded and behavior is set to Terminate oldest session, the authenticator calls handleLimitExceeded(userSessionsForClient, userClientLimit) first. if the user has fewer existing sessions for the current client than userClientLimit - 1, getNumberOfSessionsThatNeedToBeLoggedOut() returns a negative value and Stream.limit(negative) throws IllegalArgumentException, producing a 500 on every login to that client. This change ensures that getNumberOfSessionsThatNeedToBeLoggedOut returns 0 if the calculated value is negative. The dependent execution steps remain unchanged. A result of 0 sessions to be purged from the current client triggers the removal of the oldest sessions across all clients. also added a regression test in UserSessionLimitsTest that reproduces the scenario: realm limit=2, client limit=3, two logins on client-a to saturate the realm, then login on client-b (0 existing client sessions). Fixes keycloak#48040 --------- Signed-off-by: Martin Krcka <martin.krcka@adesso.de> Signed-off-by: Martin Bartoš <mabartos@redhat.com> Co-authored-by: Mateen Anjum <mateenali66@gmail.com> Co-authored-by: Martin Bartoš <mabartos@redhat.com> (cherry picked from commit 953cd26)
This was referenced Apr 16, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
keycloak#48064) * when the realm session limit is exceeded and behavior is set to Terminate oldest session, the authenticator calls handleLimitExceeded(userSessionsForClient, userClientLimit) first. if the user has fewer existing sessions for the current client than userClientLimit - 1, getNumberOfSessionsThatNeedToBeLoggedOut() returns a negative value and Stream.limit(negative) throws IllegalArgumentException, producing a 500 on every login to that client. This change ensures that getNumberOfSessionsThatNeedToBeLoggedOut returns 0 if the calculated value is negative. The dependent execution steps remain unchanged. A result of 0 sessions to be purged from the current client triggers the removal of the oldest sessions across all clients. also added a regression test in UserSessionLimitsTest that reproduces the scenario: realm limit=2, client limit=3, two logins on client-a to saturate the realm, then login on client-b (0 existing client sessions). Fixes keycloak#48040 --------- Signed-off-by: Martin Krcka <martin.krcka@adesso.de> Signed-off-by: Martin Bartoš <mabartos@redhat.com> Co-authored-by: Mateen Anjum <mateenali66@gmail.com> Co-authored-by: Martin Bartoš <mabartos@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when the realm session limit is exceeded and behavior is set to Terminate oldest session, the authenticator calls
handleLimitExceeded(userSessionsForClient, userClientLimit) first.
if the user has fewer existing sessions for the current client than userClientLimit - 1, getNumberOfSessionsThatNeedToBeLoggedOut() returns a negative value and Stream.limit(negative) throws IllegalArgumentException, producing a 500 on every login to that client.
This change ensures that getNumberOfSessionsThatNeedToBeLoggedOut returns 0 if the calculated value is negative. The dependent execution steps remain unchanged.
A result of 0 sessions to be purged from the current client triggers the removal of the oldest sessions across all clients.
also added a regression test in UserSessionLimitsTest that reproduces the scenario: realm limit=2, client limit=3, two logins on client-a to saturate the realm, then login on client-b (0 existing client sessions).
Fixes #48040