8000 fix(session-limits): guard against negative stream limit when realm limit exceeded but client is not by mateenali66 · Pull Request #48062 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix(session-limits): guard against negative stream limit when realm limit exceeded but client is not #48062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mateenali66 wants to merge 1 commit into from
Closed

fix(session-limits): guard against negative stream limit when realm limit exceeded but client is not #48062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .../keycloak/authentication/authenticators/sessionlimits/UserSessionLimitsAuthenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,9 @@ private List<UserSessionModel> handleLimitExceeded(AuthenticationFlowContext con
*/
private List<UserSessionModel> logoutOldestSessions(List<UserSessionModel> userSessions, long limit, EventBuilder eventBuilder) {
long numberOfSessionsThatNeedToBeLoggedOut = getNumberOfSessionsThatNeedToBeLoggedOut(userSessions.size(), limit);
if (numberOfSessionsThatNeedToBeLoggedOut <= 0) {
return Collections.emptyList();
}
if (numberOfSessionsThatNeedToBeLoggedOut == 1) {
logger.info("Logging out oldest session");
} else {
Expand Down
34 changes: 34 additions & 0 deletions .../tests/base/src/test/java/org/keycloak/testsuite/sessionlimits/UserSessionLimitsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,40 @@ public void testClientSessionCountExceededAndNewSessionDeniedDirectGrantFlow() t
assertEquals(ERROR_TO_DISPLAY, response.getError());
}

@Test
public void testRealmSessionLimitExceededButClientLimitNotExceededShouldNotThrow() throws Exception {
// Reproduces: realm limit exceeded on client-a, then login to client-b whose client
// session count is below the client limit. Without the fix, logoutOldestSessions()
// receives a negative count and Stream.limit() throws IllegalArgumentException.
try {
setAuthenticatorConfigItem(DefaultAuthenticationFlows.DIRECT_GRANT_FLOW, UserSessionLimitsAuthenticatorFactory.BEHAVIOR, UserSessionLimitsAuthenticatorFactory.TERMINATE_OLDEST_SESSION);
setAuthenticatorConfigItem(DefaultAuthenticationFlows.DIRECT_GRANT_FLOW, UserSessionLimitsAuthenticatorFactory.USER_REALM_LIMIT, "2");
setAuthenticatorConfigItem(DefaultAuthenticationFlows.DIRECT_GRANT_FLOW, UserSessionLimitsAuthenticatorFactory.USER_CLIENT_LIMIT, "3");

AccessTokenResponse response = oauth.client("direct-grant-1", "password")
.doPasswordGrantRequest("test-user@localhost", "password");
assertEquals(200, response.getStatusCode());

response = oauth.client("direct-grant-1", "password")
.doPasswordGrantRequest("test-user@localhost", "password");
assertEquals(200, response.getStatusCode());

// realm limit reached (2 sessions on direct-grant-1); direct-grant-2 has 0 sessions,
// below the client limit of 3. login must succeed and must not throw a 500.
response = oauth.client("direct-grant-2", "password")
.doPasswordGrantRequest("test-user@localhost", "password");
assertEquals(200, response.getStatusCode());

testingClient.server(realmName).run(assertSessionCount(realmName, username, 2));
testingClient.server(realmName).run(assertClientSessionCount(realmName, username, "direct-grant-1", 1));
testingClient.server(realmName).run(assertClientSessionCount(realmName, username, "direct-grant-2", 1));
} finally {
setAuthenticatorConfigItem(DefaultAuthenticationFlows.DIRECT_GRANT_FLOW, UserSessionLimitsAuthenticatorFactory.BEHAVIOR, UserSessionLimitsAuthenticatorFactory.DENY_NEW_SESSION);
setAuthenticatorConfigItem(DefaultAuthenticationFlows.DIRECT_GRANT_FLOW, UserSessionLimitsAuthenticatorFactory.USER_REALM_LIMIT, "0");
setAuthenticatorConfigItem(DefaultAuthenticationFlows.DIRECT_GRANT_FLOW, UserSessionLimitsAuthenticatorFactory.USER_CLIENT_LIMIT, "1");
}
}

@Test
public void testRealmSessionCountAndClientSessionCountExceededAndOldestClientSessionShouldBePrioritized() throws Exception {
try {
Expand Down
0