8000 Account UI throws error when opening an unknown path by mabartos · Pull Request #48054 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Account UI throws error when opening an unknown path - #48054

Merged
ssilvert merged 1 commit into
keycloak:mainfrom
mabartos:KC-40602
Apr 15, 2026
Merged

ssilvert merged 1 commit into
keycloak:mainfrom
mabartos:KC-40602

Conversation

@mabartos
@mabartos mabartos commented Apr 14, 2026 •
Copy link
Copy Markdown
Member

New behavior

Screencast.From.2026-04-15.10-00-19.mp4

@ssilvert @edewit @ahus1 Could you please check it? Thanks!

@mabartos
mabartos requested a review from edewit April 14, 2026 16:00
@mabartos mabartos self-assigned this Apr 14, 2026
@mabartos
mabartos requested review from a team as code owners April 14, 2026 16:00
@ssilvert ssilvert left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just one suggestion.

Comment thread js/apps/account-ui/src/root/Root.tsx Resolved
@mabartos
Copy link
Copy Markdown
Member Author

@ssilvert Works to me; updated.

Comment thread js/apps/account-ui/src/root/Root.tsx Resolved
@mabartos
mabartos requested review from edewit and ssilvert April 15, 2026 07:21
@mabartos
mabartos marked this pull request as draft April 15, 2026 07:43
Closes keycloak#40602

Co-authored-by: Stan Silvert <ssilvert@redhat.com>
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
Copy link
Copy Markdown
Member Author

@ssilvert @edewit THanks for your review; updated.

@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#loginWithExistingUserWithBruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for value to contain (ignoring case) "sign in to". Current value: "AUTH_RESPONSE" (tried for 5 second(s) with 500 milliseconds interval)
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Windows Server 2025', os.arch: 'amd64', os.version: '10.0', java.version: '17.0.18'
Driver info: org.jboss.arquillian.drone.webdriver.htmlunit.DroneHtmlUnitDriver_ByGraphene
...

Report flaky test

@mabartos
mabartos marked this pull request as ready for review April 15, 2026 09:37
@ssilvert
ssilvert merged commit fa1423d into keycloak:main Apr 15, 2026
83 checks passed
mabartos added a commit to mabartos/keycloak that referenced this pull request Apr 15, 2026
Closes keycloak#40602

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Co-authored-by: Stan Silvert <ssilvert@redhat.com>
(cherry picked from commit fa1423d)
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
Closes keycloak#40602

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Co-authored-by: Stan Silvert <ssilvert@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account UI reports "Something went wrong" when opening an unknown path

3 participants

0