Repository navigation
moved AdminEnvironment to seperate file - #48039
Merged
Merged
Conversation
fixes: keycloak#48038 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Contributor
Author
|
@ssilvert this resolves some bundle error, could you have a look? |
ssilvert
requested changes
May 21, 2026
Contributor
There was a problem hiding this comment.
This looks ok but Claude has these suggestions. I would ignore number two. One and three sound like good ideas to me.
- Rename environment.d.ts → environment-types.ts (or types/environment.ts) and update imports to the standard ./environment-types path. This avoids the unusual .d suffix convention and is unambiguous to TypeScript tooling.
- Split the RootRoute cleanup into a separate commit or PR with a clear description, since it's an unrelated change.
- Add type keyword to the PageNav.tsx import (import type { Environment }) as a minor cleanup while you're touching it.
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
ssilvert
approved these changes
May 26, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
* moved AdminEnvironment to seperate file fixes: keycloak#48038 Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> * code review Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> --------- Signed-off-by: 8000 Erik Jan de Wit <erikjan.dewit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #48038
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com