8000 makes redirect uris validation more relaxed by edewit · Pull Request #48004 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

makes redirect uris validation more relaxed - #48004

Merged
vmuzikar merged 2 commits into
keycloak:mainfrom
edewit:issue-47247-2
Apr 15, 2026
Merged

vmuzikar merged 2 commits into
keycloak:mainfrom
edewit:issue-47247-2

Conversation

@edewit
@edewit edewit commented Apr 13, 2026
Copy link
Copy Markdown
Contributor

fixes: #47247
Signed-off-by: Erik Jan de Wit erikjan.dewit@gmail.com

fixes: keycloak#47247
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
String trimmedUri = uri.trim();

// Special cases that are always valid
if ("*".equals(trimmedUri) || "+".equals(trimmedUri) || "-".equals(trimmedUri)) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be + and - for?

@edewit edewit Apr 15, 2026 •
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the help text:

Valid URI pattern a browser can redirect to after a successful logout. A value of '+' or an empty field uses the list of valid redirect URIs. A value of '-' does not allow any post logout redirect URIs. Simple wildcards are allowed such as 'http://example.com/'. A relative path can be specified too, such as /my/relative/path/. Relative paths are relative to the client root URL; if none is specified, the auth server root URL is used.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks.

@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmuzikar
vmuzikar merged commit 54f7885 into keycloak:main Apr 15, 2026
85 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
@edewit
edewit deleted the issue-47247-2 branch June 11, 2026 09:03
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
* makes redirect uris validation more relaxed

fixes: keycloak#47247
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

* updated existing test

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>

---------

Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relax URL validations in Client v2

2 participants

0