8000 RAR scope parsing should explicitly accept client reference by mabartos · Pull Request #48981 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

RAR scope parsing should explicitly accept client reference - #48981

Merged
rmartinc merged 1 commit into
keycloak:mainfrom
mabartos:KC-48980
May 18, 2026
Merged

RAR scope parsing should explicitly accept client reference#48981
rmartinc merged 1 commit into
keycloak:mainfrom
mabartos:KC-48980

Conversation

@mabartos
@mabartos mabartos commented May 13, 2026 •
edited
Loading
Copy link
Copy Markdown
Member

@mabartos mabartos mentioned this pull request May 13, 2026
Closed
@mabartos
mabartos marked this pull request as ready for review May 13, 2026 19:20
@mabartos
mabartos requested review from a team as code owners May 13, 2026 19:20
@mabartos mabartos self-assigned this May 13, 2026
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 13, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented May 13, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testNoFailureResetForPermanentLockout

Keycloak CI - Base IT (5)

org.opentest4j.AssertionFailedError: Expected error event ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

rmartinc
rmartinc reviewed May 14, 2026
View reviewed changes
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanmks @mabartos! In services we can don't have to maintain compatibility. And with this change I kind of prefer removing the old method and just adding the new signature. But not a strong opinion. If you want to main this as it is, it's OK to me.

Comment thread services/src/main/java/org/keycloak/protocol/oidc/rar/AuthorizationRequestParserProvider.java Resolved
@mabartos
mabartos marked this pull request as draft May 14, 2026 10:06
@mabartos
RAR scope parsing should explicitly accept client reference
df79796 
Closes keycloak#48980

Closes keycloak#45716

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
mabartos marked this pull request as ready for review May 14, 2026 15:04
@mabartos
mabartos requested a review from rmartinc May 15, 2026 07:47
rmartinc
rmartinc approved these changes May 18, 2026
View reviewed changes
@rmartinc rmartinc left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mabartos! LGTM!

@rmartinc
rmartinc merged commit 0981d24 into keycloak:main May 18, 2026
87 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
Closed
@u3r u3r mentioned this pull request Jun 23, 2026
Closed
rmartinc pushed a commit to rmartinc/keycloak that referenced this pull request Jun 24, 2026
@mabartos @rmartinc
RAR scope parsing should explicitly accept client reference (keycloak…
3981b41 
…#48981)

Closes keycloak#48980

Closes keycloak#45716

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@rmartinc rmartinc mentioned this pull request Jun 24, 2026
Merged
ahus1 pushed a commit that referenced this pull request Jun 29, 2026
@rmartinc @mabartos
RAR scope parsing should explicitly accept client reference (26.6)
b0f3ad5 
* Dynamic scopes: requested scopes get mixed up between token requests (#48955)

Closes #12223

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

* RAR scope parsing should explicitly accept client reference (#48981)

Closes #48980

Closes #45716

Signed-off-by: Martin Bartoš <mabartos@redhat.com>

---------

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Co-authored-by: Martin Bartoš <mabartos@redhat.com>
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@mabartos @sashyo
RAR scope parsing should explicitly accept client reference (keycloak…
f5f1b8a 
…#48981)

Closes keycloak#48980

Closes keycloak#45716

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmartinc rmartinc rmartinc approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mabartos mabartos

Labels

flaky-test team/cloud-native team/core-authn team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

2 participants

@mabartos @rmartinc
0