Repository navigation
fix: simplifying quarkus integration test annotations - #48977
Merged
Merged
Conversation
shawkins
force-pushed
the
test-annotations
branch
from
May 13, 2026 19:09
7779582 to
3ba19c9
Compare
shawkins
marked this pull request as ready for review
May 13, 2026 21:06
Pepo48
requested changes
May 13, 2026
shawkins
force-pushed
the
test-annotations
branch
2 times, most recently
from
May 14, 2026 20:37
3a67d8a to
250a798
Compare
michalvavrik
approved these changes
May 14, 2026
shawkins
force-pushed
the
8000
test-annotations
branch
from
May 14, 2026 22:04
250a798 to
4e5ff06
Compare
Pepo48
previously approved these changes
May 15, 2026
shawkins
force-pushed
the
test-annotations
branch
from
May 15, 2026 17:50
4e5ff06 to
a0dd7c4
Compare
closes: keycloak#48796 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
vmuzikar
reviewed
May 19, 2026
shawkins
force-pushed
the
test-annotations
branch
from
May 19, 2026 19:04
a0dd7c4 to
680f19a
Compare
KeycloakRunner replaces KeycloakDistributionDecorator Signed-off-by: Steve Hawkins <shawkins@redhat.com>
shawkins
force-pushed
the
test-annotations
branch
from
May 19, 2026 21:08
680f19a to
7aed6ff
Compare
vmuzikar
approved these changes
May 20, 2026
Comment on lines
+63
to
+64
| delegate.setEnvVar("KC_DEBUG", "true"); | ||
| delegate.setEnvVar("KC_DEBUG_SUSPEND", "y"); |
Contributor
There was a problem hiding this comment.
Just a nitpick. Seems we have setEnvVar in KeycloakRunner. Why not to use that instead of calling the delegate directly?
Approving regardless.
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
* fix: simplifying quarkus integration test annotations closes: keycloak#48796 Signed-off-by: Steve Hawkins <shawkins@redhat.com> * refining quarkus integration tests to use KeycloakDistributionDecorator Signed-off-by: Steve Hawkins <shawkins@redhat.com> * implementing review feedback. KeycloakRunner replaces KeycloakDistributionDecorator Signed-off-by: Steve Hawkins <shawkins@redhat.com> --------- Signed-off-by: Steve Hawkins <shawkins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the Storage annotation, and tried to aggregate all the places that are controlling the server lifecycle.
It would take more work, but we could even consider just having the DistributionTest annotation and allowing it to be specified at a method level, and do away with the specialized annotations.
closes: #48796