8000 Move the rest of TestingResource methods to a utils-shared helper class (1/2) by vaceksimon · Pull Request #48722 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Move the rest of TestingResource methods to a utils-shared helper class (1/2) - #48722

Merged
stianst merged 3 commits into
keycloak:mainfrom
vaceksimon:48708-Testing-client-and-RunOnServer
May 21, 2026
Merged

stianst merged 3 commits into
keycloak:mainfrom
vaceksimon:48708-Testing-client-and-RunOnServer

Conversation

@vaceksimon
Copy link
Copy Markdown
Contributor

Closes: #48708

@vaceksimon
vaceksimon force-pushed the 48708-Testing-client-and-RunOnServer branch 3 times, most recently from 352690f to 2f18f8e Compare May 12, 2026 16:14
@vaceksimon vaceksimon changed the title Move the rest of TestingResource methods to a utils-shared helper class Move the rest of TestingResource methods to a utils-shared helper class (1/2) May 12, 2026
@vaceksimon
vaceksimon force-pushed the 48708-Testing-client-and-RunOnServer branch 2 times, most recently from 5b23ef0 to c814c7e Compare May 13, 2026 11:26
@vaceksimon
vaceksimon marked this pull request as ready for review May 13, 2026 13:29
@vaceksimon
vaceksimon requested review from a team as code owners May 13, 2026 13:29
@vaceksimon vaceksimon added area/test-framework Test framework — infrastructure, Realm DSL, page objects, migration utils and removed team/cloud-native team/core-clients team/core-iam labels May 13, 2026
@vaceksimon
vaceksimon requested review from lhanusov and stianst May 13, 2026 13:30
@stianst stianst left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if instead of runOnServerMaster and having RunHelpers that take the test realm as the input would it not be better to just use runOnServer for the test realm in the first place?

@vaceksimon
vaceksimon force-pushed the 48708-Testing-client-and-RunOnServer branch 3 times, most recently from e5de5f0 to 205d6cb Compare May 20, 2026 09:54
…ss (1/2)

Closes: keycloak#48708

Signed-off-by: Simon Vacek <simonvacky@email.cz>
Signed-off-by: Simon Vacek <simonvacky@email.cz>
Signed-off-by: Simon Vacek <simonvacky@email.cz>
@vaceksimon
vaceksimon force-pushed the 48708-Testing-client-and-RunOnServer branch from 205d6cb to 4da61e1 Compare May 20, 2026 11:45
@vaceksimon
vaceksimon requested a review from stianst May 20, 2026 12:57
@stianst stianst self-assigned this May 21, 2026
@stianst
stianst enabled auto-merge (squash) May 21, 2026 05:39
@stianst
stianst merged commit 440f9a9 into keycloak:main May 21, 2026
142 of 144 checks passed
@vaceksimon
vaceksimon deleted the 48708-Testing-client-and-RunOnServer branch May 21, 2026 07:53
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
…ss (1/2) (keycloak#48722)

* Move the rest of TestingResource methods to a utils-shared helper class (1/2)

Closes: keycloak#48708

Signed-off-by: Simon Vacek <simonvacky@email.cz>

* rename runOnServer field

Signed-off-by: Simon Vacek <simonvacky@email.cz>

* remove realm name from method input

Signed-off-by: Simon Vacek <simonvacky@email.cz>

---------

Signed-off-by: Simon Vacek <simonvacky@email.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test-framework Test framework — infrastructure, Realm DSL, page objects, migration utils team/cloud-native team/core-clients team/core-iam

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move the rest of TestingResource methods to a utils-shared helper class (1/2)

2 participants

0