8000 Refactor SSSD tests to use JUnit5 Assertions. by lhanusov · Pull Request #48673 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Refactor SSSD tests to use JUnit5 Assertions. - #48673

Merged
stianst merged 1 commit into
keycloak:mainfrom
lhanusov:48669
May 4, 2026
Merged

Refactor SSSD tests to use JUnit5 Assertions.#48673
stianst merged 1 commit into
keycloak:mainfrom
lhanusov:48669

Conversation

@lhanusov
@lhanusov lhanusov commented May 4, 2026
Copy link
Copy Markdown
Contributor

Closes #48669

@lhanusov
lhanusov requested review from a team as code owners May 4, 2026 12:03
@lhanusov
Refactor SSSD tests to use JUnit5 Assertions.
e4823cc 
Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
@lhanusov lhanusov self-assigned this May 4, 2026
@lhanusov lhanusov added the area/test-framework Test framework — infrastructure, Realm DSL, page objects, migration utils label May 4, 2026
@keycloak-github-bot
keycloak-github-bot Bot commented May 4, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testNoFailureResetForPermanentLockout

Keycloak CI - Base IT (5)

org.opentest4j.AssertionFailedError: Expected error event ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 4, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@lhanusov
lhanusov requested review from stianst and vaceksimon May 4, 2026 13:25
@stianst stianst self-assigned this May 4, 2026
@stianst
stianst enabled auto-merge (squash) May 4, 2026 14:00
@stianst
stianst merged commit 8cfd971 into keycloak:main May 4, 2026
138 of 140 checks passed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 4, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented May 4, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BruteForceTest#testNoFailureResetForPermanentLockout

Keycloak CI - Base IT (5)

org.opentest4j.AssertionFailedError: Expected error event ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

@stianst stianst mentioned this pull request Jun 1, 2026
Closed
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@lhanusov @sashyo
Refactor SSSD tests to use 8000 JUnit5 Assertions. (keycloak#48673)
f585b55 
Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst Awaiting requested review from stianst
@vaceksimon vaceksimon Awaiting requested review from vaceksimon
1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@stianst stianst

@lhanusov lhanusov

Labels

area/test-framework Test framework — infrastructure, Realm DSL, page objects, migration utils flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor SSSD tests to use JUnit 5 Assertions class.

2 participants

@lhanusov @stianst
0