Repository navigation
Rewrite AssertEvents expectLogout and expectLogoutError into EventAssertion methods. - #48638
Merged
Merged
Conversation
lhanusov
marked this pull request as ready for review
May 4, 2026 10:57
lhanusov
force-pushed
the
48620
branch
3 times, most recently
from
May 4, 2026 12:58
bf416ac to
4a08aab
Compare
stianst
reviewed
May 5, 2026
| events.expectLogout(offlineSession.getSessionId()) | ||
| .detail(Details.LOGOUT_TRIGGERED_BY_REQUIRED_ACTION, RequiredAction.UPDATE_PASSWORD.name()) | ||
| .assertEvent(); | ||
| EventRepresentation eventRep = events.poll(); |
Contributor
There was a problem hiding this comment.
Should skip a fixed number of events, and not do a loop
Contributor
Author
There was a problem hiding this comment.
Thanks for this comment, I've decided to fix the test rather then adding a skip loop.
stianst
requested changes
May 5, 2026
Contributor
There was a problem hiding this comment.
One minor thing to change; don't use a loop, but instead skip X events
…ertion methods. Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
stianst
approved these changes
May 6, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…ertion methods. (keycloak#48638) Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48620