Repository navigation
Remove form data from the registerNode and unregisterNode method signature - #48633
Merged
Merged
Conversation
…ature Closes keycloak#48628 Signed-off-by: rmartinc <rmartinc@redhat.com>
msdaly200
approved these changes
May 1, 2026
Contributor
There was a problem hiding this comment.
LGTM, and good test coverage - validates that (multiple for JWT) form parameters are available during authentication.
stianst
approved these changes
May 4, 2026
This was referenced May 6, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…ature (keycloak#48633) Closes keycloak#48628 Signed-off-by: rmartinc <rmartinc@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48628
PR to remove the form data from the register and unregister node. The problem is that using it in the method signature makes the form decoded and is missing for the authentication of the client. This makes the method fail for authentications that require the form parameters (like
client_id,client_secretor even the assertion when using a jwt authentication). Test added. I have added the two methods to the oauth client, let me know if this is OK for you.