Repository navigation
Refactor builders in testsuite part 2 - #48454
Merged
Merged
Conversation
stianst
force-pushed
the
tf-realm-cleanup-refactor-2
branch
3 times, most recently
from
April 27, 2026 05:51
1d98d90 to
802958a
Compare
This was referenced Apr 27, 2026
stianst
force-pushed
the
tf-realm-cleanup-refactor-2
branch
3 times, most recently
from
April 27, 2026 08:26
291847d to
8426330
Compare
This was referenced Apr 27, 2026
stianst
force-pushed
the
tf-realm-cleanup-refactor-2
branch
3 times, most recently
from
April 27, 2026 09:10
9ecc43b to
55e4634
Compare
stianst
force-pushed
the
tf-realm-cleanup-refactor-2
branch
4 times, most recently
from
April 27, 2026 12:27
7f23cae to
8c75187
Compare
10000
lhanusov
suggested changes
Apr 27, 2026
|
|
||
| import static org.keycloak.models.jpa.entities.RealmAttributes.ACTION_TOKEN_GENERATED_BY_USER_LIFESPAN; | ||
|
|
||
| public class RealmAttributesBuilder { |
Contributor
There was a problem hiding this comment.
do you plan to have it as an extension to Builder class?
Contributor
Author
There was a problem hiding this comment.
No, no need for that
| public RealmBuilder client(ClientRepresentation client) { | ||
| rep.setClients(Collections.combine(rep.getClients(), client)); | ||
| @Deprecated | ||
| public RealmBuilder publicKey(String publicKey) { |
Contributor
There was a problem hiding this comment.
is it for backward compatibility?
| rep.setClients(Collections.combine(rep.getClients(), client)); | ||
| return ClientBuilder.update(client).enabled(true).clientId(clientId); | ||
| @Deprecated | ||
| public RealmBuilder privateKey(String privateKey) { |
Contributor
There was a problem hiding this comment.
is it for backward compatibility?
| @@ -75,7 +74,7 @@ public void beforeBrokerTest() { | |||
| // refresh flow to find its id | |||
| clientFlow = findFlowByAlias(clientFlow.getAlias(), realmResource.flows().getFlows()); | |||
|
|
|||
| AuthenticationExecutionRepresentation execution = ExecutionBuilder.create() | |||
| AuthenticationExecutionRepresentation execution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |||
Contributor
There was a problem hiding this comment.
plus add import
Suggested change
| AuthenticationExecutionRepresentation execution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |
| AuthenticationExecutionRepresentation execution = AuthenticationExecutionBuilder.create() |
| @@ -63,7 +62,7 @@ public void beforeBrokerTest() { | |||
| } | |||
|
|
|||
| private void addExecution(AuthenticationManagementResource authMgmtResource, String flowId, String providerId, int priority) { | |||
| AuthenticationExecutionRepresentation exec = ExecutionBuilder.create() | |||
| AuthenticationExecutionRepresentation exec = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |||
Contributor
There was a problem hiding this comment.
plus add import
Suggested change
| AuthenticationExecutionRepresentation exec = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |
| AuthenticationExecutionRepresentation exec = AuthenticationExecutionBuilder.create() |
| .id("username password form") | ||
| .parentFlow(this.flow.getId()) | ||
| .requirement(AuthenticationExecutionModel.Requirement.REQUIRED.name()) | ||
| .authenticator(UsernamePasswordFormFactory.PROVIDER_ID) | ||
| .build(); | ||
|
|
||
| AuthenticationExecutionRepresentation authScriptExecution = ExecutionBuilder.create() | ||
| AuthenticationExecutionRepresentation authScriptExecution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() |
Contributor
There was a problem hiding this comment.
Suggested change
| AuthenticationExecutionRepresentation authScriptExecution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |
| AuthenticationExecutionRepresentation authScriptExecution = AuthenticationExecutionBuilder.create() |
| @@ -185,7 +184,7 @@ public void loginShouldFailWithScriptAuthenticator() { | |||
| */ | |||
| @Test | |||
| public void scriptWithClientSession() { | |||
| AuthenticationExecutionRepresentation authScriptExecution = ExecutionBuilder.create() | |||
| AuthenticationExecutionRepresentation authScriptExecution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |||
Contributor
There was a problem hiding this comment.
Suggested change
| AuthenticationExecutionRepresentation authScriptExecution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |
| AuthenticationExecutionRepresentation authScriptExecution = AuthenticationExecutionBuilder.create() |
| @@ -152,14 +151,14 @@ public void configureFlows() throws Exception { | |||
|
|
|||
| this.flow = findFlowByAlias(scriptFlow); | |||
|
|
|||
| AuthenticationExecutionRepresentation usernamePasswordFormExecution = ExecutionBuilder.create() | |||
| AuthenticationExecutionRepresentation usernamePasswordFormExecution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |||
Contributor
There was a problem hiding this comment.
plus add import
Suggested change
| AuthenticationExecutionRepresentation usernamePasswordFormExecution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |
| AuthenticationExecutionRepresentation usernamePasswordFormExecution = AuthenticationExecutionBuilder.create() |
| .id("username password form") | ||
| .parentFlow(this.flow.getId()) | ||
| .requirement(AuthenticationExecutionModel.Requirement.REQUIRED.name()) | ||
| .authenticator(UsernamePasswordFormFactory.PROVIDER_ID) | ||
| .build(); | ||
|
|
||
| AuthenticationExecutionRepresentation authScriptExecution = ExecutionBuilder.create() | ||
| AuthenticationExecutionRepresentation authScriptExecution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() |
Contributor
There was a problem hiding this comment.
Suggested change
| AuthenticationExecutionRepresentation authScriptExecution = org.keycloak.testframework.realm.AuthenticationExecutionBuilder.create() | |
| AuthenticationExecutionRepresentation authScriptExecution = AuthenticationExecutionBuilder.create() |
Contributor
Author
There was a problem hiding this comment.
Updating
| @@ -35,38 +35,25 @@ | |||
| <dependency> | |||
| <groupId>org.keycloak</groupId> | |||
| <artifactId>keycloak-core</artifactId> | |||
| <exclusions> | |||
Contributor
There was a problem hiding this comment.
removing this exclusion -> wouldn't it bring multiple unused dependencies inside the test framework?
Contributor
Author
There was a problem hiding this comment.
Doesn't matter as the framework as a dep on this regardless due to the embedded server
stianst
marked this pull request as ready for review
April 27, 2026 13:09
This was referenced Apr 27, 2026
Flaky test: org.keycloak.testsuite.model.singleUseObject.SingleUseObjectModelTest#testCluster
#48441
Closed
Closed
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.model.user.UserModelTest#testAddDirtyRemoveFederationUsersInTheSameGroupConcurrentKeycloak CI - Store Model Tests |
Closes keycloak#48452 Signed-off-by: stianst <stianst@gmail.com>
stianst
force-pushed
the
tf-realm-cleanup-refactor-2
branch
from
April 27, 2026 13:48
8c75187 to
a140e2b
Compare
stianst
enabled auto-merge (squash)
April 27, 2026 14:34
ahus1
approved these changes
Apr 28, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
Closes keycloak#48452 Signed-off-by: stianst <stianst@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48452
Signed-off-by: stianst stianst@gmail.com