Repository navigation
Fix device user code input styling in keycloak.v2 login theme - #47283
Merged
Merged
Conversation
kathari00
force-pushed
the
fix/device-user-code-patternfly
branch
from
March 19, 2026 09:01
51e88ed to
9b29c91
Compare
edewit
requested changes
Mar 23, 2026
Comment on lines
+12
to
+19
| <#assign error = messagesPerField.get("device_user_code")> | ||
| <@field.group name="device-user-code" label=msg("verifyOAuth2DeviceUserCode") error=error> | ||
| <span class="${properties.kcInputClass} <#if error?has_content>${properties.kcError}</#if>"> | ||
| <input id="device-user-code" name="device_user_code" autocomplete="off" type="text" autofocus dir="ltr" | ||
| aria-invalid="<#if error?has_content>true</#if>"/> | ||
| <@field.errorIcon error=error /> | ||
| </span> | ||
| </@field.group> |
Contributor
There was a problem hiding this comment.
Can't it be done by this
Suggested change
| <#assign error = messagesPerField.get("device_user_code")> | |
| <@field.group name="device-user-code" label=msg("verifyOAuth2DeviceUserCode") error=error> | |
| <span class="${properties.kcInputClass} <#if error?has_content>${properties.kcError}</#if>"> | |
| <input id="device-user-code" name="device_user_code" autocomplete="off" type="text" autofocus dir="ltr" | |
| aria-invalid="<#if error?has_content>true</#if>"/> | |
| <@field.errorIcon error=error /> | |
| </span> | |
| </@field.group> | |
| <@field.input name="device_user_code" label=msg("verifyOAuth2DeviceUserCode") autofocus=true /> | |
edewit
reviewed
Mar 23, 2026
Comment on lines
+21
to
+23
| <@buttons.actionGroup> | ||
| <@buttons.button id="kc-login" label="doSubmit" class=["kcButtonPrimaryClass", "kcButtonBlockClass"] /> | ||
| </@buttons.actionGroup> |
Contributor
There was a problem hiding this comment.
Suggested change
| <@buttons.actionGroup> | |
| <@buttons.button id="kc-login" label="doSubmit" class=["kcButtonPrimaryClass", "kcButtonBlockClass"] /> | |
| </@buttons.actionGroup> | |
| <@buttons.loginButton /> |
Contributor
Author
|
The same issue applies to |
kathari00
force-pushed
the
fix/device-user-code-patternfly
branch
2 times, most recently
from
April 3, 2026 09:11
892d41b to
3435884
Compare
Contributor
Author
|
I Incorporated the review and I also fixed |
edewit
approved these changes
Apr 8, 2026
Signed-off-by: kathari00 <katharina.eiserfey1@gmail.com>
ahus1
force-pushed
the
fix/device-user-code-patternfly
branch
from
April 8, 2026 14:43
3435884 to
d5fe2db
Compare
ahus1
previously approved these changes
Apr 8, 2026
ahus1
enabled auto-merge (squash)
April 8, 2026 14:44
Member
|
Thank you for this contribution! Once it is merged, it would be great if you could provide a backport to the 26.6 release branch, and then we would include it in the next 26.6 patch release. |
Signed-off-by: Alexander Schwartz <alexander.schwartz@ibm.com>
ahus1
approved these changes
Apr 10, 2026
Member
@kathari00 - With this change of the ID of the fields, I'm no longer 100% sure if this should be backported to 26.6 or not. If you would like to see the change in 26.6 instead of waiting for another 3 months, please let me know and prepare the backport. If not, then we just wait for the next release. |
Contributor
Author
|
Thanks for taking a look! The change is not urgent. |
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
Fixes keycloak#46463 Signed-off-by: kathari00 <katharina.eiserfey1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46463
When entering a code for the OAuth 2.0 Device Authorization Grant on the device verification page, the input field was not rendered with the expected PatternFly styling in the keycloak.v2 login theme.
This change adds the missing keycloak.v2 template for the device user code page so the code input is rendered like the other PatternFly-styled login form fields.