Repository navigation
Not possible to sync latest keycloak-admin-client to keycloak-client - #47950
Merged
Merged
Conversation
closes keycloak#47889 Signed-off-by: mposolda <mposolda@gmail.com>
Member
mposolda
added a commit
to mposolda/keycloak
that referenced
this pull request
Apr 13, 2026
…eycloak#47950) closes keycloak#47889 Signed-off-by: mposolda <mposolda@gmail.com> (cherry picked from commit 15ede46)
mposolda
added a commit
that referenced
this pull request
Apr 14, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…eycloak#47950) closes keycloak#47889 Signed-off-by: mposolda <mposolda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #47889
As described in #47889, it is not possible to sync keycloak-admin-client in keycloak-clients .
The
keycloak-admin-client-testsnow declares dependency onkeycloak-admin-v2-rest. That module contains new Client V2 API and is compatible only with Java 17 (admin client is compatible with Java 11 and that's the version, which is supposed to work forkeycloak-admin-clientin the keycloak-client repository ). Due to this, it is not possible to sync the currentkeycloak-admin-client-teststo thekeycloak-admin-clientin keycloak-client repository.Approaches I considered to address the issue:
Make sure that it is possible to sync
keycloak-admin-clientwithout dependency onkeycloak-admin-v2-rest.Make sure that
keycloak-admin-clientis synced to keycloak-client repository together with all new stuff (classClientsas well as the librarykeycloak-admin-v2-rest).I used approach (1) as:
keycloak-clients is supposed to be Java 11, but
keycloak-admin-v2-resthas compatibility with Java 17Official admin client version
keycloak-admin-clientfrom keycloak-clients is supposed to preserve backwards compatibility. But I guess the API introduced for Clients V2 is still under development and there are not any backwards compatibility requirements yet as it is experimental feature?This PR does only that method
Keycloak.clients()uses reflection to createClientsinstance, so that classorg.keycloak.admin.client.wrapper.Clientsis not directly imported inKeycloakclass. Hence it is possible to syncKeycloakclass in the keycloak-client without syncing also classClientsand wholekeycloak-admin-v2-restlibrary.