8000 Migration Tool - Adding ApiUtil rewrite. by lhanusov · Pull Request #47937 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Migration Tool - Adding ApiUtil rewrite. - #47937

Closed
lhanusov wants to merge 1 commit into
keycloak:mainfrom
lhanusov:37283/migration-tool_apiutil
Closed

lhanusov wants to merge 1 commit into
keycloak:mainfrom
lhanusov:37283/migration-tool_apiutil

Conversation

@lhanusov
Copy link
Copy Markdown
Contributor
8000

No description provided.

Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
@lhanusov
lhanusov marked this pull request as ready for review April 10, 2026 09:54
@lhanusov
lhanusov requested a review from a team as a code owner April 10, 2026 09:54
@stianst stianst left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing a quick grep/search there's 507 uses of ApiUtil in the old testsuite (excluding getCreatedId).

This may be a good case for just refactoring it in the old testsuite to match the new testsuite?

@stianst
stianst commented Apr 10, 2026
Copy link
8000 Copy Markdown
Contributor

Sent an alternative proposal that refactors the old testsuite instead: #47942

@stianst stianst closed this Apr 10, 2026
@stianst
stianst commented Apr 10, 2026
Copy link
Copy Markdown
Contributor

We ended up refactoring this in the old testsuite instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0