8000 [OID4VCI] Default client scopes not configured correctly by tdiesler · Pull Request #47903 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

[OID4VCI] Default client scopes not configured correctly #47903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mposolda merged 1 commit into from
Apr 14, 2026
Merged

[OID4VCI] Default client scopes not configured correctly #47903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion services/src/main/java/org/keycloak/protocol/oid4vc/OID4VCLoginProtocolFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import org.keycloak.protocol.oid4vc.issuance.OID4VCIssuerEndpoint;
import org.keycloak.protocol.oid4vc.issuance.mappers.OID4VCSubjectIdMapper;
import org.keycloak.protocol.oid4vc.issuance.mappers.OID4VCUserAttributeMapper;
import org.keycloak.protocol.oid4vc.model.ProofType;
import org.keycloak.protocol.oidc.OIDCLoginProtocolFactory;
import org.keycloak.representations.idm.ClientRepresentation;
import org.keycloak.representations.idm.ClientScopeRepresentation;
Expand All @@ -55,6 +56,8 @@
import static org.keycloak.models.ClientScopeModel.INCLUDE_IN_TOKEN_SCOPE;
import static org.keycloak.models.oid4vci.CredentialScopeModel.CRYPTOGRAPHIC_BINDING_METHODS_DEFAULT;
import static org.keycloak.models.oid4vci.CredentialScopeModel.VCT;
import static org.keycloak.models.oid4vci.CredentialScopeModel.VC_BINDING_REQUIRED;
import static org.keycloak.models.oid4vci.CredentialScopeModel.VC_BINDING_REQUIRED_PROOF_TYPES;
import static org.keycloak.models.oid4vci.CredentialScopeModel.VC_BUILD_CONFIG_HASH_ALGORITHM;
import static org.keycloak.models.oid4vci.CredentialScopeModel.VC_BUILD_CONFIG_HASH_ALGORITHM_DEFAULT;
import static org.keycloak.models.oid4vci.CredentialScopeModel.VC_BUILD_CONFIG_SD_JWT_VISIBLE_CLAIMS;
Expand All @@ -81,7 +84,6 @@ public class OID4VCLoginProtocolFactory implements LoginProtocolFactory, OID4VCE

private static final Logger LOGGER = Logger.getLogger(OID4VCLoginProtocolFactory.class);

private static final String CLIENT_ROLES_MAPPER = "client-roles";
private static final String USERNAME_MAPPER = "username";
private static final String SUBJECT_ID_MAPPER = "subject-id";
private static final String EMAIL_MAPPER = "email";
Expand Down Expand Up @@ -141,6 +143,11 @@ public void createDefaultClientScopes(RealmModel newRealm, boolean addScopesToEx
clientScope.addProtocolMapper(builtins.get(LAST_NAME_MAPPER));

ClientScopeRepresentation clientScopeRep = ModelToRepresentation.toRepresentation(clientScope);
clientScopeRep.setAttributes(new HashMap<>(Map.of(
VC_BINDING_REQUIRED, "true",
VC_BINDING_REQUIRED_PROOF_TYPES, ProofType.JWT + "," + ProofType.ATTESTATION
)));

addClientScopeDefaults(clientScopeRep);
RepresentationToModel.updateClientScope(clientScopeRep, clientScope);
}
Expand Down
164 changes: 0 additions & 164 deletions tests/base/src/test/java/org/keycloak/tests/admin/client/ClientScopeTestOid4Vci.java
View file
Open in desktop

This file was deleted.

Loading
Loading
0