8000 fix: remove extra dependencies from the operator by shawkins · Pull Request #47902 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

fix: remove extra dependencies from the operator - #47902

Merged
vmuzikar merged 1 commit into
keycloak:release/26.6from
shawkins:iss47872-backport
Apr 9, 2026
Merged

vmuzikar merged 1 commit into
keycloak:release/26.6from
shawkins:iss47872-backport

Conversation

@shawkins
@shawkins shawkins commented Apr 9, 2026
Copy link
Copy Markdown
Contributor

closes: #47872

An alternative for main is #47874

But we can always proceed with this fix there as well first, then refine further.

closes: keycloak#47872

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins marked this pull request as ready for review April 9, 2026 13:08
@shawkins
shawkins requested review from a team as code owners April 9, 2026 13:08
@vmuzikar
vmuzikar commented Apr 9, 2026
Copy link
Copy Markdown
Contributor

But we can always proceed with this fix there as well first, then refine further.

+1, i'd wait with the bigger refactor for the generalization of the API "framework"

@shawkins
shawkins commented Apr 9, 2026
Copy link
Copy Markdown
Contributor Author

+1, i'd wait with the bigger refactor for the generalization of the API "framework"

I wouldn't couple those together necessarily. #47889 is going to be messy unless we better minimize our dependencies.

@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmuzikar
vmuzikar merged commit 26c6807 into keycloak:release/26.6 Apr 9, 2026
83 checks passed
@vmuzikar
vmuzikar commented Apr 9, 2026
Copy link
Copy Markdown
Contributor

@shawkins So this PR won't be enough to resolve #47889 for 26.6?

@shawkins
shawkins commented Apr 9, 2026
Copy link
Copy Markdown
Contributor Author

@shawkins So this PR won't be enough to resolve #47889 for 26.6?

No, this just hides transitive dependencies from the operator. I believe @mposolda is already looking at a fix.

In general to build the new client classes you need a substancial classpath, which seems like a bad practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0