8000 Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry by Pepo48 · Pull Request #47896 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry - #47896

Merged
vmuzikar merged 1 commit into
keycloak:quarkus-nextfrom
Pepo48:issue-47895
Apr 22, 2026
Merged

Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry#47896
vmuzikar merged 1 commit into
keycloak:quarkus-nextfrom
Pepo48:issue-47895

Conversation

@Pepo48
@Pepo48 Pepo48 commented Apr 9, 2026
Copy link
Copy Markdown
Contributor

This PR deliberately does not close its parent issue - it is going to be closed once merged to main.

@Pepo48
Pepo48 requested review from a team as code owners April 9, 2026 09:50
@Pepo48 Pepo48 mentioned this pull request Apr 9, 2026
Merged
@vmuzikar
vmuzikar commented Apr 9, 2026
Copy link
Copy Markdown
Contributor

Do I understand correctly, this PR cannot go to main until the next Quarkus upgrade?

@Pepo48
Pepo48 commented Apr 9, 2026
Copy link
Copy Markdown
Contributor Author

Do I understand correctly, this PR cannot go to main until the next Quarkus upgrade?

Correct. Meanwhile, it's targeted for quarkus-next.

@github-actions
github-actions Bot force-pushed the quarkus-next branch 6 times, most recently from 6be04eb to d1b7800 Compare April 15, 2026 00:33
vmuzikar
vmuzikar approved these changes Apr 15, 2026
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge if tests pass.

mabartos
mabartos approved these changes Apr 15, 2026
View reviewed changes
@mabartos mabartos left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mabartos
mabartos commented Apr 15, 2026
Copy link
Copy Markdown
Member

@Pepo48 Not passed :/

Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project keycloak-quarkus-server: Compilation failure
Error:  /home/runner/work/keycloak/keycloak/quarkus/runtime/src/main/java/org/keycloak/quarkus/runtime/tracing/OTelHttpClientFactory.java:[51,108] cannot find symbol
Error:    symbol:   method createHttpClientBuilder()
Error:    location: class io.opentelemetry.instrumentation.apachehttpclient.v4_3.ApacheHttpClientTelemetry
Error:  -> [Help 1]

@Pepo48
Pepo48 commented Apr 15, 2026
Copy link
Copy Markdown
Contributor Author

I suspect it's because quarkus-next was not yet updated. We can leave it for the scheduled action and try again tomorrow or somebody with permission should be able to do it earlier via:
gh workflow run "Quarkus Next" -R keycloak/keycloak

Then I expect this PR to fix the issue (I verified it locally last week).

@Pepo48 Pepo48 mentioned this pull request Apr 16, 2026
Merged
@github-actions
github-actions Bot force-pushed the quarkus-next branch 6 times, most recently from 776185e to 411e300 Compare April 22, 2026 00:52
@Pepo48
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry
c76fef7 
Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
@Pepo48
Pepo48 commented Apr 22, 2026
Copy link
Copy Markdown
Contributor Author

Quarkus-next run after the necessary PRs were merged yesterday: https://github.com/keycloak/keycloak/actions/runs/24754331750/job/72424228189

This PR should solve the build error there. I did the rebase so let's wait for the results.

github-actions Bot pushed a commit that referenced this pull request May 5, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
44f43f9 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 6, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
6798608 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 7, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
0b31031 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 10, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
0780f2b 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 11, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
71800a9 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 12, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
37babeb 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 14, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
ae8b40c 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 15, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
f720caf 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 16, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
232258e 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 19, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
ee53847 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 20, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
93033a9 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 21, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
58097e5 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 22, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
d98f9b3 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 23, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
3c44a00 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 24, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
3dcf785 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 25, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
6141d7e 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 26, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
5b4301c 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 27, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
43ba667 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 28, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
8d42445 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 29, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
f789ccc 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request May 31, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
20b2534 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
github-actions Bot pushed a commit that referenced this pull request Jun 1, 2026
@Pepo48 @github-actions
Adapt to OTel instrumentation API change in ApacheHttpClientTelemetry (…
55d8652 
…#47896)

Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
@Pepo48 Pepo48 mentioned this pull request Jul 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
@mabartos mabartos mabartos approved these changes

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pepo48 @vmuzikar @mabartos
0