Repository navigation
Pin Azure CLI to 2.82.0 to fix JSON parsing error - #47828
Merged
Merged
Conversation
Closes: keycloak#47827 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
michalvavrik
reviewed
Apr 7, 2026
|
|
||
| if [[ "$ACTION" == "create" ]]; then | ||
| # Pin Azure CLI to 2.82.0 (azure-core 1.38.0+ causes JSON parsing errors with az vm create) | ||
| sudo apt-get install -y -q --allow-downgrades azure-cli=2.82.0-1~noble |
Member
There was a problem hiding this comment.
Please bear in your mind I have a limited knowledge about Azure CLI and I also don't know what is a common practice in this project. Still, I'll tell you what I think 😄 :
Should you link TODO with link to an opened issue so that you don't loose track of this? Or what are upgrade plans? I'd go even further and say without linked upstream issue or documentation saying which Azure CLI can be used under certain conditions, this is fantastic workaround, but we will need to revisit it at some point in the future and define when exactly we should use Azure CLI 2.82.0-1-noble and under which conditions we can proceed to the newest version.
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.model.session.UserSessionProviderOfflineModelTest#testOfflineSessionLazyLoadingKeycloak CI - Store Model Tests org.keycloak.testsuite.model.session.UserSessionProviderModelTest#testStreamsMarshallingKeycloak CI - Store Model Tests org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNodeKeycloak CI - Store Model Tests org.keycloak.testsuite.model.session.UserSessionProviderModelTest#testCreateUserSessionsParallelKeycloak CI - Store Model Tests org.keycloak.testsuite.model.session.UserSessionProviderModelTest#testStreamsMarshallingKeycloak CI - Store Model Tests org.keycloak.testsuite.model.session.UserSessionPersisterProviderTest#testExpirationDistributionKeycloak CI - Store Model Tests |
stianst
approved these changes
Apr 8, 2026
stianst
pushed a commit
to stianst/keycloak
that referenced
this pull request
Apr 8, 2026
Closes: keycloak#47827 Signed-off-by: Peter Zaoral <pzaoral@redhat.com> (cherry picked from commit 2a4c9e0)
stianst
added a commit
that referenced
this pull request
Apr 8, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
Closes: keycloak#47827 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #47827
The full version string is deliberate (otherwise apt does not find the package).
Test run: https://github.com/Pepo48/keycloak/actions/runs/24098525925/job/70303546307