Repository navigation
[OID4VCI] Fix OID4VCI token typ defaults by credential format - #47779
Merged
Merged
Conversation
closes keycloak#45420 Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
forkimenjeckayang
force-pushed
the
issue-45420
branch
from
April 7, 2026 07:15
ad16a5c to
4bef949
Compare
closes keycloak#45420 Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
forkimenjeckayang
force-pushed
the
issue-45420
branch
from
April 8, 2026 10:29
4bef949 to
8d85e32
Compare
Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
mposolda
approved these changes
Apr 8, 2026
Contributor
There was a problem hiding this comment.
@forkimenjeckayang Thanks!
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
…ak#47779) closes keycloak#45420 Signed-off-by: forkimenjeckayang <forkimenjeckayang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the default
token_jws_typefor OID4VCI to be credential format–specific (dc+sd-jwtfor SD-JWT andvc+jwtfor JWT VC) instead of the genericJWS. It preserves flexibility by keeping the field non-blocking, applies backend defaults when empty, and adds a non-blocking UI warning for mismatched values. Tests and documentation are updated accordingly.Addresses: #45420 (comment)
closes #45420