Repository navigation
Inject theme descriptions and make paths dynamic - #47771
Merged
Merged
Conversation
Contributor
Author
|
@edewit Tagging you on this because your name is in the blame for QuickTheme.tsx |
Contributor
Author
|
We may want to turn the sanitizing code into a helper function and create tests for it, if the proposed implementation is agreed upon. |
edewit
previously approved these changes
Apr 7, 2026
Contributor
Author
|
Changed PR to Ready for Review for merging and rebased so branch is up to date with main. |
deweesevs
force-pushed
the
jar-enhancement
branch
from
April 7, 2026 15:06
18ca477 to
287ea2f
Compare
deweesevs
force-pushed
the
jar-enhancement
branch
from
April 9, 2026 17:37
287ea2f to
feb4537
Compare
Added message bundles to custom themes so descriptions are now automatically rendered to user Sanitize theme names for dynamic paths to allow multiple themes rendering at once Closes keycloak#47762 Signed-off-by: Benjamin DeWeese <benjamin@deweese.cc>
deweesevs
force-pushed
the
jar-enhancement
branch
from
April 9, 2026 17:41
feb4537 to
46db2c8
Compare
ohbus
approved these changes
Apr 15, 2026
Contributor
|
Quick note, once this PR is handled, I'll open mine for ticket #47866, since it will use themeNameClean as the fallback rendered name. Thanks! |
edewit
approved these changes
Apr 29, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
Added message bundles to custom themes so descriptions are now automatically rendered to user Sanitize theme names for dynamic paths to allow multiple themes rendering at once Closes keycloak#47762 Signed-off-by: Benjamin DeWeese <benjamin@deweese.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added message bundles to custom themes so descriptions are now automatically rendered to user
Sanitize theme names for dynamic paths to allow multiple themes rendering at once
With these proposed changes, users can import multiple themes (so long as they are not all named
quick-theme) and view their descriptions.Also, please let me know it this should be done in 2 PRs. Thank you,
Closes #47762