8000 fix: mapping mtls enabled to a runtime option by shawkins · Pull Request #47751 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

fix: mapping mtls enabled to a runtime option - #47751

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss47750
Apr 7, 2026
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss47750

Conversation

@shawkins
@shawkins shawkins commented Apr 3, 2026
Copy link
Copy Markdown
Contributor

closes: #47750

We also don't want to advertise spi options that we already have first-class options for.

vmuzikar
vmuzikar previously approved these changes Apr 7, 2026
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vmuzikar
vmuzikar commented Apr 7, 2026
Copy link
Copy Markdown
Contributor

@shawkins Can you please rebase?

@shawkins
shawkins commented Apr 7, 2026
Copy link
Copy Markdown
Contributor Author

@shawkins Can you please rebase?

Updated.

closes: keycloak#47750

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this change for as much as I understand it. I'll leave it to others to fully approve it due to my lack of knowledge in the Quarkus side of things.

It definitely makes sense to have this a runtime option, and not a build time option.

@vmuzikar
vmuzikar enabled auto-merge (squash) April 7, 2026 14:50
@vmuzikar
vmuzikar merged commit 0b0f2b7 into keycloak:main Apr 7, 2026
144 of 146 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
closes: keycloak#47750

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cache-embedded-mtls-enabled maps to a build time property, but is a runtime option

3 participants

0