Repository navigation
Migration Tool - Removing AbstractKeycloak extends. - #47691
Merged
Merged
Conversation
stianst
reviewed
Apr 9, 2026
| for (int i = 0; i < content.size(); i++) { | ||
| String l = content.get(i); | ||
| if (l.contains("extends AbstractKeycloakTest")) { | ||
| replaceLine(i, l.replace("extends AbstractKeycloakTest", "")); |
Contributor
There was a problem hiding this comment.
Suggested change
| replaceLine(i, l.replace("extends AbstractKeycloakTest", "")); | |
| replaceLine(i, l.replace(" extends AbstractKeycloakTest", "")); |
stianst
reviewed
Apr 9, 2026
| } | ||
|
|
||
| if (l.contains("extends AbstractTestRealmKeycloakTest")) { | ||
| replaceLine(i, l.replace("extends AbstractTestRealmKeycloakTest", "")); |
Contributor
There was a problem hiding this comment.
Suggested change
| replaceLine(i, l.replace("extends AbstractTestRealmKeycloakTest", "")); | |
| replaceLine(i, l.replace(" extends AbstractTestRealmKeycloakTest", "")); |
stianst
reviewed
Apr 9, 2026
| break; | ||
| } | ||
|
|
||
| if (l.contains("extends AbstractTestRealmKeycloakTest")) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (l.contains("extends AbstractTestRealmKeycloakTest")) { | |
| if (l.contains(" extends AbstractTestRealmKeycloakTest")) { |
stianst
reviewed
Apr 9, 2026
| if (abstractImport >= 0 || abstractTestRealmImport >= 0) { | ||
| for (int i = 0; i < content.size(); i++) { | ||
| String l = content.get(i); | ||
| if (l.contains("extends AbstractKeycloakTest")) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (l.contains("extends AbstractKeycloakTest")) { | |
| if (l.contains(" extends AbstractKeycloakTest")) { |
stianst
requested changes
Apr 9, 2026
Contributor
There was a problem hiding this comment.
Results in two spaces public class HostnameV2Test { fix would be to update search/ and replace to extends .. instead of just extends .. see suggested changes
Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
lhanusov
force-pushed
the
37283/migration-tool_extends
branch
from
April 10, 2026 09:15
7c6a697 to
84dfd96
Compare
stianst
approved these changes
Apr 10, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47517