Repository navigation
Migrate events package to test framework - #47403
Merged
Merged
Conversation
Closes keycloak#47401 Signed-off-by: stianst <stianst@gmail.com>
lhanusov
suggested changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
Thanks for this PR, please take a look and consider updating it, based on my comments.
lhanusov
approved these changes
Mar 25, 2026
stianst
enabled auto-merge (squash)
March 25, 2026 13:28
vmuzikar
approved these changes
Mar 25, 2026
| @InjectTimeOffSet | ||
| TimeOffSet timeOffSet; | ||
|
|
||
| EventRunOnServerHelper eventHelper; |
Contributor
There was a problem hiding this comment.
Should we make this injectable via CDI? Seems helpful and generic enough to be reused in other tests possibly.
| } | ||
|
|
||
| protected TestingResource testing() { | ||
| return getTestingClient().testing(); |
Contributor
There was a problem hiding this comment.
Unrelated to this line. Should we clean up the TestingResource from the no longer used endpoints related to events? Or is it a follow-up?
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
Closes keycloak#47401 Signed-off-by: stianst <stianst@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47401
Signed-off-by: stianst stianst@gmail.com