Repository navigation
Stop using jboss-parent - #46241
Stop using jboss-parent#46241
Conversation
|
@stianst @ASzc @drichtarik Does this work for you? |
|
We are running test builds and adding dependencies/plugins that are missing. This is going to take a couple of days but it's included in the upcoming sprint as our goal |
There was a problem hiding this comment.
This is not going to work for the release; we're relying on a few bits and pieces from jboss-parent there. Need to look into exactly what, but don't have time right now.
|
@stianst sorry for dragging you into this again, I hadn’t noticed that you were tagged. I’ve already discussed it with Denis and as he mentioned above, they’re currently looking into what needs to be done from the downstream perspective. Once they finish, I’ll be ready to use the testing org to verify whether anything else needs to be adjusted to fix the release workflows at that level as well. |
|
The latest changes successfully tested on keycloak-rel-testing org. |
I'm surprised - was really certain gpg or something around repo config wouldn't be right. I'll take a look at this next week just to make double sure; as I really don't want to fight issues around this when we do the 26.6 release ;) |
8be258a to
b11f15d
Compare
Closes: keycloak#40125 Signed-off-by: Peter Zaoral <pzaoral@redhat.com>
Should match the versions from jboss-parent to prevent conflicting versions. Signed-off-by: Badiuzzaman Iskhandar <badiskhand@ibm.com>
| <maven-assembly-plugin.version>3.1.1</maven-assembly-plugin.version> | ||
| <maven-deploy-plugin.version>2.8.2</maven-deploy-plugin.version> | ||
| <maven-jar-plugin.version>3.5.0</maven-jar-plugin.version> | ||
| <maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version> |
There was a problem hiding this comment.
Quarkus is using maven-compiler 3.15.0, while you picked 3.13.0. Is this in order to align with Maven core and other plugins? Because only information in your PR / commits I found was "Should match the versions from jboss-parent to prevent conflicting versions." which does not add up, because JBoss Parent version 39 currently uses 3.8.1.
There was a problem hiding this comment.
@drichtarik this got postponed a bit and now it's ready to be merged. Should we keep these versions as they are or should we bump some of them? Thanks!
There was a problem hiding this comment.
For product all we're trying to establish with the introduction of these lines, is to ensure that these plugin versions are defined. Removing jboss-parent otherwise allows them to float, which causes problems.
3.13 vs 3.15, I don't think it would matter, but we'd need to do more trial builds to confirm
There was a problem hiding this comment.
3.13 vs 3.15, I don't think it would matter, but we'd need to do more trial builds to confirm
FWIW the only reason why I was commenting here was because I tried to use annotationProcessorPathsUseDepMgmt which was introduced in 3.12. I am fine with 3.13, but it seems random and I think explanation on why these exact plugin versions were picked is missing. As long as there is a reason, np.
There was a problem hiding this comment.
We could perhaps split the two things; since we've tested this PR both for upstream and downstream releases we can keep it as is, then plan to upgrade plugins as a follow-up?
There was a problem hiding this comment.
Yes. This one has been open for a long time. If you want to merge this PR as is or with 3.15, that's fine. As long as there is a dependency definition in the keycloak POMs, we can override the version at product build time if it breaks something, upstreaming fixes as appropriate.
Because of a surefire plugin config change, see #45616 (comment) (the paragraph about the test changes) |
There was a problem hiding this comment.
Because of a surefire plugin config change, see #45616 (comment) (the paragraph about the test changes)
Right, I forgot about that. Thanks, LGTM.
* Stop using jboss-parent Closes: keycloak#40125 Signed-off-by: Peter Zaoral <pzaoral@redhat.com> * Add Maven plugins version from jboss-parent Should match the versions from jboss-parent to prevent conflicting versions. Signed-off-by: Badiuzzaman Iskhandar <badiskhand@ibm.com> --------- Signed-off-by: Peter Zaoral <pzaoral@redhat.com> Signed-off-by: Badiuzzaman Iskhandar <badiskhand@ibm.com> Co-authored-by: Badiuzzaman Iskhandar <badiskhand@ibm.com>
Closes: #40125