8000 Fix null username creation when SAML attribute mapper references missing attribute by kvfi · Pull Request #44664 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Fix null username creation when SAML attribute mapper references missing attribute - #44664

Closed
kvfi wants to merge 0 commit into
keycloak:mainfrom
kvfi:main
Closed

kvfi wants to merge 0 commit into
keycloak:mainfrom
kvfi:main

Conversation

@kvfi
@kvfi kvfi commented Dec 4, 2025 •
Copy link
Copy Markdown
Contributor

Validates that username template mappers produce non-empty results and prevents empty usernames from being created when the SAML mapping attributes are missing.

Closes #44598

@sguilhen sguilhen left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @kvfi . It looks good to me.

@keycloak/core-maintainers can anyone trigger the CI for this one?

@sguilhen
Copy link
Copy Markdown
Contributor

@kvfi Can you run mvn spotless:apply locally to fix the imports, then update the PR? It is failing due to the new import checks.

@kvfi
kvfi commented Feb 27, 2026
Copy link
Copy Markdown
Contributor Author

@kvfi Can you run mvn spotless:apply locally to fix the imports, then update the PR? It is failing due to the new import checks.

Linted and pushed.

@pedroigor pedroigor left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures seem related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SAML user created with null username when mapped attribute missing

3 participants

0