8000 Run account console resource tests in parallel by jonkoops · Pull Request #43316 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Run account console resource tests in parallel - #43316

Merged
ssilvert merged 1 commit into
keycloak:mainfrom
jonkoops:isolate-resouces-test
Oct 14, 2025
Merged

ssilvert merged 1 commit into
keycloak:mainfrom
jonkoops:isolate-resouces-test

Conversation

@jonkoops
@jonkoops jonkoops commented Oct 9, 2025 •
Copy link
Copy Markdown
Contributor

Refactors the account console resource tests (resources.spec.ts) to execute in parallel, speeding up test execution. Additionally, two tests with repeated logic have been merged into one. This PR also refactors some other code to make use of explicit resource management to automatically close browsers.

Closes #43315

@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.oauth.ClientAuthSignedJWTTest#testClientWithGeneratedKeysJKS

Keycloak CI - Base IT (6)

java.lang.AssertionError: 

Expected: (a value greater than <1854703220688L> and a value less than <1854703230688L>)
     but: a value greater than <1854703220688L> <1854703219000L> was less than <1854703220688L>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

@jonkoops jonkoops changed the title Run account console resource tests in parralel Run account console resource tests in parallel Oct 9, 2025
@jonkoops
jonkoops force-pushed the isolate-resouces-test branch from 431d2b3 to 0f72aad Compare October 10, 2025 14:56
@jonkoops
jonkoops marked this pull request as ready for review October 10, 2025 14:56
@jonkoops
jonkoops requested review from a team as code owners October 10, 2025 14:56
Closes keycloak#43315

Signed-off-by: Jon Koops <jonkoops@gmail.com>
@jonkoops
jonkoops force-pushed the isolate-resouces-test branch from 0f72aad to 5f9562e Compare October 10, 2025 15:07
@ssilvert
ssilvert merged commit 55c53d3 into keycloak:main Oct 14, 2025
@jonkoops
jonkoops deleted the isolate-resouces-test branch October 14, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove serial test execution for resources.spec.ts

2 participants

0