8000 Node registration fix by wvdhaute · Pull Request #4205 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Node registration fix - #4205

Closed
wvdhaute wants to merge 2 commits into
keycloak:masterfrom
wvdhaute:master
Closed

wvdhaute wants to merge 2 commits into
keycloak:masterfrom
wvdhaute:master

Conversation

@wvdhaute
@wvdhaute wvdhaute commented Jun 2, 2017
Copy link
Copy Markdown
Contributor

Bugfix for node registration

@stianst
stianst comment 8000 ed Jun 2, 2017
Copy link
Copy Markdown
Contributor

Please add tests and create a JIRA bug report

@mposolda
mposolda commented Jun 8, 2017
Copy link
Copy Markdown
Contributor

@wvdhaute This looks like a workaround. I am not sure why the formParameters can't be read directly in the authenticator and why it requires the separate session attribute. Please create JIRA with some details.

@mposolda mposolda closed this Jun 15, 2017
@wvdhaute
Copy link
Copy Markdown
Contributor Author

@mposolda Sorry for the late answer, created a JIRA issue

I agree that it feels like a workaround, I've quickly dug a bit into the keycloak code but had no luck yet why this happens

@mposolda
Copy link
Copy Markdown
Contributor

I've closed this because:

  • The PR contains 2 changes unrelated to each other. We ideally want to have every PR focused on one thing.
  • There are no JIRAs for any of those 2 changes in PR and there are no tests
  • I think that both changes are either workarounds or not needed.
  1. For formParameters I don't have clue why it's even needed. See my comment above. Please create JIRA with steps to reproduce.
  2. Admin REST endpoint for validating user password - not sure if we want this OOTB. If we have similar endpoint, it won't be tightly coupled to "password" credential, but generic endpoint for credentials validation. Anyway, we already have possibility of pluggable REST endpoints. So you can add custom REST endpoint for validating passwords in your environment without a need to change anything inside Keycloak codebase.

@wvdhaute
Copy link
Copy Markdown
Contributor Author

Sorry, lazily did not make a feature branch and committed the validatePassword on the same PR
Reverted that one fyi

123445666 pushed a commit to 123445666/keycloak that referenced this pull request Mar 10, 2023
…#4205)

Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.48.0 to 5.48.1.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.48.1/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0