Repository navigation
Allow target attribute for anchor tags in html-sanitizer - #42700
Merged
Merged
Conversation
rr-it
force-pushed
the
fix/target-for-achors
branch
from
September 17, 2025 14:24
9a2dba4 to
b621b02
Compare
ahus1
requested changes
Sep 17, 2025
Member
There was a problem hiding this comment.
Thank you for this PR for this issue that has several upvotes. Please see below for a suggested change.
| @@ -102,6 +102,7 @@ public class KeycloakSanitizerPolicy { | |||
| .allowStandardUrlProtocols() | |||
| .allowAttributes("nohref").onElements("a") | |||
| .allowAttributes("name").matching(NAME).onElements("a") | |||
| .allowAttributes("target").matching(NAME).onElements("a") | |||
Member
There was a problem hiding this comment.
I would like to be more restrictive here and not just allow any target, but only _blank. This is the most common case that is being asked for, and also avoid opening content in an already named window.
When you add a change to allow only _blank, please add also a test that shows that other targets are not allowed.
rr-it
force-pushed
the
fix/target-for-achors
branch
from
September 18, 2025 15:31
b621b02 to
53cb6bf
Compare
ahus1
approved these changes
Sep 19, 2025
Member
There was a problem hiding this comment.
Thank you for the PR. I slightly adjusted the test case, as the sanitation library will only add the additional rel values when the target is accepted.
ahus1
enabled auto-merge (squash)
September 19, 2025 07:00
Member
|
Waiting for #42752 to be fixed first |
Signed-off-by: Ayke Halder <rr-it@users.noreply.github.com>
ahus1
force-pushed
the
fix/target-for-achors
branch
from
September 19, 2025 08:40
0fecfea to
59df3d2
Compare
This was referenced Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kcSanitizeallows for atargetattribute in anchor tags.Especially on the registration or accept terms of service page the links to terms of service must open in a new window. If the link opens in the same window, the user is thrown out of the registration or login process.
Therefore the html-sanitizer must not remove the
targetattribute from anchor tags like:<a href="…" target="_blank">…</a>This fixes #28846