Repository navigation
KEYCLOAK-4950 - #4185
KEYCLOAK-4950 #4185
Conversation
|
Does this also generate the licenses for the npm based UI code? |
|
@johnament license-maven-plugin only uses information from the maven model, so any non-maven components of Keycloak will not be included. This is certainly just a first step. |
|
I've changed the system to a manual data gathering process, for both Java and non-Java. The html is still generated at build-time. I need to fix the xsl to include non-Java data, and to use the correct local license file path. |
c9fe4b6 to
b02538d
Compare
|
I have updated the xsl to display the non-Java data in the html. |
c1daecf to
2e74e70
Compare
|
Is this ready to go now? |
There was a problem hiding this comment.
I would imagine you pick the more liberal license here (Apache 2) over the more restrictive (GPLv2). This seems to indicate opposite.
There was a problem hiding this comment.
The symbolic link here doesn't reflect any decision on which license Keycloak chooses to use for Select2. That project doesn't offer discrete license texts in its source code, so both license files have identical text, so they get symlinked for deduplication purposes.
There was a problem hiding this comment.
Looks like select2 is actually MIT from their website at least? https://select2.github.io/
There was a problem hiding this comment.
That's true for the modern versions, but the version in use in 7.1.0 is licensed as ASL v2 or GPL v2. https://github.com/select2/select2/blob/3.4.1/LICENSE
There was a problem hiding this comment.
It may be MIT in newer versions, but if the version used in here is this dual license thats fine. I think the confusing part is that this almost looks like a reflective link (A ->B, B -> A) so someone parsing the licenses may not be clear on the declaration.
I think tracking the upgrade separately makes sense as well, as this is a licensing headache from my POV (as one of the guys who have to consume these).
There was a problem hiding this comment.
The way I would recommend reading the license data is to start with the xml or the html. Then, if additional information is desired for a particular component's license, either use the remote URL or access the local file. The regular filenames make it easy to programmatically find local files when processing the xml data. The symlinks avoid the bloat this regular naming scheme would otherwise cause.
There was a problem hiding this comment.
You should exclude the HTML markup from the TXT file.
There was a problem hiding this comment.
That would be a bug to file against Keycloak separately. I don't know why the license file is HTML. Beyond line-ending normalization, I don't think automatically changing any of the license texts is wise. Doing so could potentially change the meaning of the license.
|
Re-targeted for the actual 7.1.x branch |
licenses.xml was manually collected with the assistance of some external scripts. The download-license-files.sh script is included for updating the local license copies when licenses.xml is changed.
maven-resources-plugin must not be used for the individual license files, as it doesn't preserve symlinks. They are included directly by maven-assembly-plugin, which does preserve symlinks.
Properties like ${product.slot} and ${product.name.full} are not available in this branch, but should be used instead of the hardcoded values in pom.xml and assembly.xml when porting to master.
|
Got the wrong directory for the adapters, new PR here. |
Include license data from RH-SSO 7.1.0 release. Other branches can be updated later using the tools and configuration introduced here.
licenses.xml was manually collected with the assistance of some external scripts. The
download-license-files.shscript is included for updating the local license copies when licenses.xml is changed.PREVIOUSLY:
Generate licenses.xml and licenses.html using the same system as Wildfly/EAP, and include in the server-feature-pack under path content/docs/licenses-keycloak/