8000 fix: removing lifecylce in initContainers by shawkins · Pull Request #40455 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10000
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,9 @@ private static void configureContainer(ContainerFluent<?> containerBuilder, Stri
containerBuilder.withVolumeMounts(newVolumeMounts);
}

// remove restart policy and probes
// remove restart policy, lifecycle, and probes
containerBuilder.withRestartPolicy(null);
containerBuilder.withLifecycle(null);
containerBuilder.withReadinessProbe(null);
containerBuilder.withLivenessProbe(null);
containerBuilder.withStartupProbe(null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.keycloak.operator.ContextUtils.DIST_CONFIGURATOR_KEY;
import static org.keycloak.operator.ContextUtils.NEW_DEPLOYMENT_KEY;
Expand Down Expand Up @@ -708,4 +709,16 @@ public void testUpdateJobSecretHandling() {
assertEquals(List.of(new LocalObjectReference("new-secret"), new LocalObjectReference("secret")), job.getSpec().getTemplate().getSpec().getImagePullSecrets());
}

@Test
public void testFieldRemovalForInitContainer() {
Job job = getUpdateJob(builder -> {
}, builder -> builder.withNewUnsupported().withNewPodTemplate().withNewSpec().addNewContainer()
.withRestartPolicy("OnFailure")
.withNewLifecycle().withNewPostStart().withNewExec().withCommand("hello").endExec().endPostStart()
.endLifecycle().endContainer().endSpec().endPodTemplate().endUnsupported(), builder -> {
});
assertNull(job.getSpec().getTemplate().getSpec().getInitContainers().get(0).getLifecycle());
assertNull(job.getSpec().getTemplate().getSpec().getInitContainers().get(0).getRestartPolicy());
}

}
0