Repository navigation
Conversation
2695552 to
974464b
Compare
c8797af to
88e2136
Compare
232c876 to
fcc575f
Compare
fcc575f to
f26a93a
Compare
adec397 to
e1acf1f
Compare
e1acf1f to
aaf699f
Compare
aaf699f to
b35b80b
Compare
There was a problem hiding this comment.
@pszabo891 The new mapper makes sense for me, but don't we want to extend the UserAttributeMapper and add the prefix logic on top of it?
|
@pedroigor I have implemented the mapper originally as a plugin, so creating a new mapper was the most straightforward way to bring the functionality into the codebase without changing existing code. I'm happy to rework it and implement as part of the |
|
I think we can have it as a separate mapper, but with the prefixing logic applied to values. The admin would usually choose between your mapper or the regular user attribute mapper, but never both, right? Another concern I have is how to solve conflicts with the root attributes, such as email, first, and last names. Now they will be prefixed and, considering they are single-valued, the last update will win? |
|
@pedroigor If we keep it as a separate mapper, you are correct, for each claim only one mapper will be needed - either the Those root attributes are only impacted by the prefixing mapper if the Administrator explicitly configures the mapper for them and then it behaves as expected, although there might not be a real use case for prefixing those attributes. Or perhaps I missed something? If prefixing the root attributes is a concern, we can also implement it so, that we skip them and apply the prefix only to the rest of the attributes. |
b35b80b to
b63f77d
Compare
Signed-off-by: Peter Szabo <petersz.szabo@gmail.com>
b63f77d to
f0fe1b8
Compare
|
From a UX perspective, keeping a single mapper is better so that we can add the Regarding the root attributes, I don't think it makes much sense to use a prefix on them. I cannot think about a use case mainly because the values would be shown everywhere. Imagine the account console showing as your first name |
|
@pedroigor I have created a new PR #42002 which adds the prefixing functionality in the existing mapper. |
|
Thanks. Closing in favor of #42002. |
The new OIDC mapper adds the possibility to prefix the values of the claims when imported into user attributes.
Closes #39929