8000 fix: removing KeycloakApplication usage of keycloak-add-user.json by shawkins · Pull Request #39460 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Repository navigation

fix: removing KeycloakApplication usage of keycloak-add-user.json - #39460

Merged
vmuzikar merged 2 commits into
keycloak:mainfrom
shawkins:iss39428
May 8, 2025
Merged

fix: removing KeycloakApplication usage of keycloak-add-user.json#39460
vmuzikar merged 2 commits into
keycloak:mainfrom
shawkins:iss39428

Conversation

@shawkins
@shawkins shawkins commented May 5, 2025
Copy link
Copy Markdown
Contributor

closes:#39428

@shawkins
shawkins force-pushed the iss39428 branch 3 times, most recently from c90ed12 to d4212a8 Compare May 5, 2025 17:33
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request May 5, 2025
7438 Closed
@shawkins
shawkins force-pushed the iss39428 branch 2 times, most recently from f4c7d0d to ff5b4d9 Compare May 5, 2025 21:09
@shawkins
shawkins marked this pull request as ready for review May 6, 2025 11:55
@shawkins
shawkins requested review from a team as code owners May 6, 2025 11:55
vmuzikar
vmuzikar reviewed May 6, 2025
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also get rid of the keycloak-add-user.json file in the testsuite? And mentions of it in POMs?

@shawkins
shawkins commented May 6, 2025
Copy link
Copy Markdown
Contributor Author

Should we also get rid of the keycloak-add-user.json file in the testsuite? And mentions of it in POMs?

My understanding was that it was still being picked up for migration testing. I can certianly add a commit with it removed, just to double check.

@vmuzikar
vmuzikar commented May 6, 2025
Copy link
Copy Markdown
Contributor

@shawkins It might be worth it, yes.

@shawkins
shawkins commented May 6, 2025
Copy link
Copy Markdown
Contributor Author

@shawkins It might be worth it, yes.

I'm surprised, it seemed to work.

@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request May 6, 2025
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 7, 2025
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented May 7, 2025
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Keycloak CI - Base IT

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/tenant2/login-action ; actual URL: https://localhost:8643/multi-tenant-saml/?realm=tenant2 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
...

Report flaky test

mabartos
mabartos approved these changes May 7, 2025 8000
View reviewed changes
@mabartos mabartos left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 7, 2025
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented May 7, 2025
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Keycloak CI - Base IT

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/tenant2/login-action ; actual URL: https://localhost:8643/multi-tenant-saml/?realm=tenant2 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
...

Report flaky test

vmuzikar
vmuzikar approved these changes May 7, 2025
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Thanks, LGTM.

@vmuzikar
vmuzikar enabled auto-merge (squash) May 7, 2025 15:18
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 7, 2025
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented May 7, 2025
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#multiTenant2SamlTest

Keycloak CI - Base IT

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in org.keycloak.testsuite.util.URLAssert URL expected to begin with: https://localhost:8543/auth/realms/tenant2/login-action ; actual URL: https://localhost:8643/multi-tenant-saml/?realm=tenant2 within 10 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
...

Report flaky test

shawkins added 2 commits May 8, 2025 09:14
@shawkins @ahus1
fix: removing KeycloakApplication usage of keycloak-add-user.json
dab71a8 
closes:keycloak#39428

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins @ahus1
Removing the test keycloak-add-user.json
4712e8a 
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@vmuzikar
vmuzikar merged commit f40cb88 into keycloak:main May 8, 2025
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed May 8, 2025
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented May 8, 2025
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.cluster.SessionFailoverClusterTest#sessionFailover

Keycloak CI - Clustering IT

java.lang.RuntimeException: java.lang.IllegalStateException: Keycloak unexpectedly died :(
	at org.keycloak.testsuite.arquillian.containers.KeycloakQuarkusServerDeployableContainer.start(KeycloakQuarkusServerDeployableContainer.java:71)
	at org.jboss.arquillian.container.impl.ContainerImpl.start(ContainerImpl.java:185)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:137)
	at org.jboss.arquillian.container.impl.client.container.ContainerLifecycleController$8.perform(ContainerLifecycleController.java:133)
...

Report flaky test

@shawkins shawkins mentioned this pull request May 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
@mabartos mabartos mabartos approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shawkins @vmuzikar @mabartos
0