8000 Simplify TimeOffsetTest to just check time is set, rather than using events which is expensive by stianst · Pull Request #38217 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Simplify TimeOffsetTest to just check time is set, rather than using events which is expensive #38217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahus1 merged 1 commit into from
Mar 18, 2025
Merged

Simplify TimeOffsetTest to just check time is set, rather than using events which is expensive #38217

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 2 additions & 39 deletions tests/base/src/test/java/org/keycloak/tests/admin/TimeOffsetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,7 @@
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.keycloak.common.util.Time;
import org.keycloak.events.Event;
import org.keycloak.events.EventStoreProvider;
import org.keycloak.events.EventType;
import org.keycloak.models.RealmModel;
import org.keycloak.storage.datastore.PeriodicEventInvalidation;
import org.keycloak.testframework.annotations.InjectRealm;
import org.keycloak.testframework.annotations.KeycloakIntegrationTest;
import org.keycloak.testframework.realm.ManagedRealm;
import org.keycloak.testframework.remote.runonserver.InjectRunOnServer;
import org.keycloak.testframework.remote.runonserver.RunOnServerClient;
import org.keycloak.testframework.remote.timeoffset.InjectTimeOffSet;
Expand All @@ -41,40 +34,10 @@ public class TimeOffsetTest {
@InjectRunOnServer
RunOnServerClient runOnServer;

@InjectRealm
ManagedRealm managedRealm;

@Test
public void testOffset() {
String realmId = managedRealm.getId();

runOnServer.run(session -> {
RealmModel realm = session.realms().getRealm(realmId);
realm.setEventsExpiration(5);
EventStoreProvider provider = session.getProvider(EventStoreProvider.class);

Event e = new Event();
e.setType(EventType.LOGIN);
e.setTime(Time.currentTimeMillis());
e.setRealmId(realmId);
provider.onEvent(e);
});

runOnServer.run(session -> {
EventStoreProvider provider = session.getProvider(EventStoreProvider.class);
Assertions.assertEquals(1, provider.createQuery().realm(realmId).getResultStream().count());
});

runOnServer.run(s -> Assertions.assertEquals(0, Time.getOffset()));
timeOffSet.set(5);
runOnServer.run(session -> {
EventStoreProvider eventStore = session.getProvider(EventStoreProvider.class);
eventStore.clearExpiredEvents();
session.invalidate(PeriodicEventInvalidation.JPA_EVENT_STORE);
});

runOnServer.run(session -> {
EventStoreProvider provider = session.getProvider(EventStoreProvider.class);
Assertions.assertEquals(0, provider.createQuery().realm(realmId).getResultStream().count());
});
runOnServer.run(s -> Assertions.assertEquals(5, Time.getOffset()));
}
}
0