Repository navigation
Generate random passwords for imported users in forms and webauthn tests - #38935
Merged
Merged
Conversation
mposolda
reviewed
Apr 15, 2025
Contributor
There was a problem hiding this comment.
@rmartinc To me, it looks good. Thanks for the work!
Regarding the failing tests:
- external links documentation test can be ignored (it is being already fixed by #38094 )
- For the UI failures, I am not 100% sure. I did not saw those in my recent PR and in the nightly build. I've tried to re-run the tests. Maybe that helps. If re-run does not help, maybe rebase helps (as there are some UI changes yesterday evening, which might fixed this, but not 100% sure...)
However if even rebase does not help, maybe it is UI themselves failing with the latest chrome. As I am not 100% sure if UI tests are also using the chrome prepared in install-chrome action? If it is the case, we can maybe keep the chrome version in this PR still at 134.0.6998.165 and merge the PR. Then there would need to be follow-up PR, which would fix the UI tests and updates chrome to default . But maybe not needed, we will see if re-run or rebase helps...
Closes keycloak#38812 Signed-off-by: rmartinc <rmartinc@redhat.com>
Contributor
Author
|
Rebased! Let's see what happens. |
mposolda
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38812
Finally to test with chrome the passwords are going to be re-genearted for imported users. The password is saved inside a map that can be retrieved during the tests. There are also helper methods to add new passwords into the map or even change the password of a user in the server and the map. All this setup is done in an abstract class called
AbstractChangeImportedUserPasswordsTestthat any other test class can extend. Modified all the tests in forms and webauthn to use the new generated passwords instead of fixed passwords and, this way, avoid security popups.CI configured back to use chrome in the ubuntu box.