Repository navigation
Conversation
MilanSMA
force-pushed
the
prompt-conditional
branch
from
April 11, 2025 12:47
86e4e77 to
e7f15cc
Compare
MilanSMA
force-pushed
the
prompt-conditional
branch
from
May 26, 2025 07:35
e7f15cc to
bf01f6b
Compare
|
Hello ! i would like to know if this MR has some chances to be merged in the near future ? thx for the great work here :-) |
prompt is an optional authentication request parameter defined by OpenId Connect Specification, the authentication flow can depend on the value of this param (for example if we want to avoid SPNEGO for prompt=login) Closes keycloak#8989 Signed-off-by: MilanSMA <sma.mduriancik@gmail.com>
MilanSMA
force-pushed
the
prompt-conditional
branch
from
August 21, 2025 09:44
bf01f6b to
2548414
Compare
Signed-off-by: MilanSMA <sma.mduriancik@gmail.com>
MilanSMA
force-pushed
the
prompt-conditional
branch
from
August 21, 2025 13:12
b28ded2 to
569d079
Compare
Contributor
|
Skipping an authenticator due to the prompt parameter makes no sense; if an application wants to decide how the user should authenticate it should use step-up authentication for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a conditional authenticator to check prompt parameters of AuthRequests (optional parameter defined by OpenId connect specification).
Closes #8989.
As the pull request #17064 has been inactive for more than 2 years (probably abandoned) I propose my solution to #8989 taking into account comments of #17064.
As suggested by @mposolda I wrote a conditional authenticator rather than a extended SPNEGO authenticator. I think the behaviour of the prompt parameter conditional is clearer and easier to understand than a "reauthenticate" conditional. But if needed I can change this.