8000 Added conditional authenticator for prompt param by MilanSMA · Pull Request #38875 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Added conditional authenticator for prompt param - #38875

Closed
MilanSMA wants to merge 3 commits into
keycloak:mainfrom
MilanSMA:prompt-conditional
Closed

MilanSMA wants to merge 3 commits into
keycloak:mainfrom
MilanSMA:prompt-conditional

Conversation

@MilanSMA
Copy link
Copy Markdown

This pull request adds a conditional authenticator to check prompt parameters of AuthRequests (optional parameter defined by OpenId connect specification).

Closes #8989.

As the pull request #17064 has been inactive for more than 2 years (probably abandoned) I propose my solution to #8989 taking into account comments of #17064.
As suggested by @mposolda I wrote a conditional authenticator rather than a extended SPNEGO authenticator. I think the behaviour of the prompt parameter conditional is clearer and easier to understand than a "reauthenticate" conditional. But if needed I can change this.

@MilanSMA
MilanSMA requested a review from a team as a code owner April 11, 2025 12:42
@MilanSMA
MilanSMA force-pushed the prompt-conditional branch from 86e4e77 to e7f15cc Compare April 11, 2025 12:47
@MilanSMA
MilanSMA force-pushed the prompt-conditional branch from e7f15cc to bf01f6b Compare May 26, 2025 07:35
@wyfrel
wyfrel commented Jun 2, 2025
Copy link
Copy Markdown

Hello ! i would like to know if this MR has some chances to be merged in the near future ?

thx for the great work here :-)

prompt is an optional authentication request parameter defined by OpenId Connect Specification,
the authentication flow can depend on the value of this param (for example if we want to avoid SPNEGO for prompt=login)

Closes keycloak#8989

Signed-off-by: MilanSMA <sma.mduriancik@gmail.com>
@MilanSMA
MilanSMA force-pushed the prompt-conditional branch from bf01f6b to 2548414 Compare August 21, 2025 09:44
Signed-off-by: MilanSMA <sma.mduriancik@gmail.com>
@MilanSMA
MilanSMA force-pushed the prompt-conditional branch from b28ded2 to 569d079 Compare August 21, 2025 13:12
@stianst
stianst commented May 7, 2026
Copy link
Copy Markdown
Contributor

Skipping an authenticator due to the prompt parameter makes no sense; if an application wants to decide how the user should authenticate it should use step-up authentication for that.

@stianst stianst closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skip kerberos SSO authentication to use login-form

3 participants

0