Repository navigation
angular2-product-app: simplify KeycloakHttp - #3855
Conversation
|
Sorry it has taken so long to look at this. I tried your code and it's not fetching the data when you click "Reload". I get a 401 "Unauthorized" error in the console when it tries to get http://localhost:8080/database/products. |
|
@ssilvert can you please provide some guidance on how to test this code? Can't figure out how to build the demo apps |
|
How did you test your code before you submitted the PR? |
|
Ok, I managed to build the app and now see that the example relies on outdated version of angular. So now there are 2 paths I can go:
What should I do? |
|
I think #2 would be best. You are thinking WebPack? |
|
Oh, you said use angular-cli. So that means definitely moving to WebPack. That would be great. |
|
I hoped for that option as well :) Ok, let me come back with more patches then |
- use `frontend-maven-plugin` to pull node/npm automatically - tie `npm install` to relevant lifecycle (`mvn wildfly:deploy` automatically builds and includes build products into WAR) - extern keycloak and product database base url, use `--env=war` to build a war colocated with keycloak and database app Issues/Todos: - when testing with `ng serve` will have to disable browser web security (product-database doesn’t allow cross-origin requests) - no unit / e2e / arquillian tests for now - `src/main/frontend/node_modules` is included in distribution build, this is a portability debt
|
@ssilvert please, review :) Features
Issues/Todos:
|
|
Looks good now. Works like a charm. Did see a couple of things in /frontend that need to be touched up before we merge:
|
|
@ssilvert Done! |
|
Great. Thanks for the contribution! |
Implement Angular 2 example from scratch using latest and greatest Anglular 2.4.x and
angular-cli