Repository navigation
fix: removing the use of hostname-strict-https mistakenly brought back - #38536
Merged
Merged
Conversation
also properly emit the http v1 check closes: keycloak#38236 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also properly emit the http v1 check. We're now using the picocli writer for the http v1 check - as deferred logging can prevent it from being seen. The only side effect is that it will be WARN instead of an ERROR, but we can of course tweak that.
Since #38514 is getting too large, these are the minimal changes which should address this. However we do have some consistency issues in how we deal with the profile that the other pr will eventually handle.
closes: #38236