8000 fix: removing the use of hostname-strict-https mistakenly brought back by shawkins · Pull Request #38536 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

fix: removing the use of hostname-strict-https mistakenly brought back - #38536

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:hostname_strict_https-b
Mar 28, 2025
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:hostname_strict_https-b

Conversation

@shawkins
@shawkins shawkins commented Mar 28, 2025 •
Copy link
Copy Markdown
Contributor

also properly emit the http v1 check. We're now using the picocli writer for the http v1 check - as deferred logging can prevent it from being seen. The only side effect is that it will be WARN instead of an ERROR, but we can of course tweak that.

Since #38514 is getting too large, these are the minimal changes which should address this. However we do have some consistency issues in how we deal with the profile that the other pr will eventually handle.

closes: #38236

also properly emit the http v1 check

closes: keycloak#38236

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@vmuzikar
vmuzikar merged commit 9444577 into keycloak:main Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

configuration related cleanups

2 participants

0