Repository navigation
Enhancement: Improve Regex for NPM Version Matching in set-version.sh - #36080
Merged
Merged
Conversation
Signed-off-by: Isaac Mercieca <isaac.mercieca@rs2.com>
isaac-mercieca
force-pushed
the
versions-regex
branch
from
December 20, 2024 08:52
ec9f521 to
829c5ec
Compare
jonkoops
approved these changes
Dec 20, 2024
Contributor
There was a problem hiding this comment.
Tested this locally and seems to work fine, LGTM.
jonkoops
enabled auto-merge (squash)
December 20, 2024 18:07
Contributor
|
Please do not merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the regex in the
set-version.shscript to ensure it matches version strings with literal dots (.) and avoids unintended patterns.The previous regex did not escape the period (
.), which could lead to incorrect matches and NPM version conversions. This enhancement refines the regex for greater reliability in handling version strings.Related Issue:
Resolves #36079