8000 Wrap scheduled tasks in a trace by ahus1 · Pull Request #36044 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
import org.keycloak.models.utils.KeycloakModelUtils;
import org.keycloak.timer.ScheduledTask;
import org.keycloak.timer.TaskRunner;
import org.keycloak.transaction.RequestContextHelper;
import org.keycloak.tracing.TracingProvider;

/**
* @author <a href="mailto:sthorger@redhat.com">Stian Thorgersen</a>
Expand All @@ -50,26 +50,32 @@ public ScheduledTaskRunner(KeycloakSessionFactory sessionFactory, ScheduledTask

@Override
public void run() {
// trace a tracing provider directly to avoid creating a transaction that is unnecessary and would a surplus JTA transaction element to it
TracingProvider tracing = sessionFactory.getProviderFactory(TracingProvider.class).create(null);
Comment thread
ahus1 marked this conversation as resolved.
Resolved
try {
KeycloakModelUtils.runJobInTransaction(sessionFactory, new NamedSessionTask("Scheduled task: " + task.getTaskName()) {
tracing.trace("ScheduledTaskRunner", task.getTaskName() + ".run", span -> {
KeycloakModelUtils.runJobInTransaction(sessionFactory, new NamedSessionTask("Scheduled task: " + task.getTaskName()) {

@Override
public void run(KeycloakSession session) {
try {
if (transactionLimit != 0) {
KeycloakModelUtils.setTransactionLimit(sessionFactory, transactionLimit);
}
@Override
public void run(KeycloakSession session) {
try {
if (transactionLimit != 0) {
KeycloakModelUtils.setTransactionLimit(sessionFactory, transactionLimit);
}

runTask(session);
} finally {
if (transactionLimit != 0) {
KeycloakModelUtils.setTransactionLimit(sessionFactory, 0);
runTask(session);
} finally {
if (transactionLimit != 0) {
KeycloakModelUtils.setTransactionLimit(sessionFactory, 0);
}
}
}
}
});
});
} catch (Throwable t) {
logger.errorf(t, "Failed to run scheduled task %s", task.getTaskName());
} finally {
tracing.close();
}
}

Expand Down
0