Repository navigation
Check minValidityToken to refresh the token if it is equals - #36043
Merged
Merged
Conversation
Closes keycloak#36038 Signed-off-by: rmartinc <rmartinc@redhat.com>
mposolda
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36038
Just forcing refresh if the remaining time is equals to minValidityToken. There are two methods (
exchangeStoredTokenandexchangeSessionToken) and in one it was less and in the other was less or equal (it was also less but in the other part of the if 😄). That's why the stored test can fail with 5 and the session test was OK.