8000 Check minValidityToken to refresh the token if it is equals by rmartinc · Pull Request #36043 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Check minValidityToken to refresh the token if it is equals - #36043

Merged
mposolda merged 1 commit into
keycloak:mainfrom
rmartinc:issue-36038
Dec 19, 2024
Merged

mposolda merged 1 commit into
keycloak:mainfrom
rmartinc:issue-36038

Conversation

@rmartinc
Copy link
Copy Markdown
Contributor

Closes #36038

Just forcing refresh if the remaining time is equals to minValidityToken. There are two methods (exchangeStoredToken and exchangeSessionToken) and in one it was less and in the other was less or equal (it was also less but in the other part of the if 😄). That's why the stored test can fail with 5 and the session test was OK.

Closes keycloak#36038

Signed-off-by: rmartinc <rmartinc@redhat.com>
@rmartinc
rmartinc requested a review from a team as a code owner December 19, 2024 12:00
@mposolda mposolda self-assigned this Dec 19, 2024
@mposolda
mposolda enabled auto-merge (rebase) December 19, 2024 12:42
@mposolda
mposolda merged commit 1fc6d59 into keycloak:main Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: org.keycloak.testsuite.broker.KcOidcBrokerTokenExchangeTest#testInternalExternalTokenExchangeStoredToken

2 participants

0