Repository navigation
BACKPORT: Fix(admin-ui): key status filtering issue in KeysListTab (#34721) - #35133
Merged
Merged
Conversation
Contributor
|
@edewit please do a sign-off. |
) Support customer reports that keys with 'Active' set to 'off' still appear in the Active keys list in the Admin console under Realms settings -> Keys -> Keys list. The root cause was identified as the filtering logic, which does not apply status-based filtering for the first item in FILTER_OPTIONS ('ACTIVE'). This commit corrects the filtering logic to properly exclude keys based on the 'Active' status selection. Closes keycloak#34675 Signed-off-by: Charley <charley.geoffroy@protonmail.com> (cherry picked from commit 46f7fb5) Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit
force-pushed
the
backport-34721-26.0
branch
from
December 2, 2024 06:43
4580c86 to
1d5cf76
Compare
Contributor
Author
|
@agagancarczyk done |
ssilvert
approved these changes
Dec 9, 2024
Closed
edewit
added a commit
to edewit/keycloak
that referenced
this pull request
Dec 11, 2024
) (keycloak#35133) Support customer reports that keys with 'Active' set to 'off' still appear in the Active keys list in the Admin console under Realms settings -> Keys -> Keys list. The root cause was identified as the filtering logic, which does not apply status-based filtering for the first item in FILTER_OPTIONS ('ACTIVE'). This commit corrects the filtering logic to properly exclude keys based on the 'Active' status selection. Closes keycloak#34675 (cherry picked from commit 46f7fb5) Signed-off-by: Charley <charley.geoffroy@protonmail.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Co-authored-by: Charley <71822392+charley04310@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support customer reports that keys with 'Active' set to 'off' still appear in the Active keys list in the Admin console under Realms settings -> Keys -> Keys list. The root cause was identified as the filtering logic, which does not apply status-based filtering for the first item in FILTER_OPTIONS ('ACTIVE'). This commit corrects the filtering logic to properly exclude keys based on the 'Active' status selection.
Closes #34675
backport: #34721
Signed-off-by: Charley charley.geoffroy@protonmail.com
(cherry picked from commit 46f7fb5)