8000 fix: changing the bootstrapping suggestion to the command (#35616) by shawkins · Pull Request #35666 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix: changing the bootstrapping suggestion to the command (#35616) - #35666

Merged
shawkins merged 1 commit into
keycloak:release/26.0from
shawkins:backport-35616-26.0
Dec 6, 2024
Merged

fix: changing the bootstrapping suggestion to the command (#35616)#35666
shawkins merged 1 commit into
keycloak:release/26.0from
shawkins:backport-35616-26.0

Conversation

@shawkins
@shawkins shawkins commented Dec 5, 2024
Copy link
Copy Markdown
Contributor

closes: #35526

Signed-off-by: Steve Hawkins shawkins@redhat.com
(cherry picked from commit 4c7dea5)

@shawkins
fix: changing the bootstrapping suggestion to the command (keycloak#3…
c8af6b1 
…5616)

closes: keycloak#35526

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 4c7dea5)
@shawkins
shawkins requested review from a team as code owners December 5, 2024 14:39
@shawkins
shawkins requested review from jonkoops and vmuzikar December 5, 2024 14:39
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Dec 5, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Dec 5, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginAgainWithoutRememberMe(LoginTest.java:693)
...

Report fla 8000 ky test

@shawkins
shawkins enabled auto-merge (squash) December 5, 2024 20:03
@shawkins
shawkins merged commit c6d06e0 into keycloak:release/26.0 Dec 6, 2024
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
edewit pushed a commit to edewit/keycloak that referenced this pull request Dec 11, 2024
@shawkins @edewit
fix: changing the bootstrapping suggestion to the command (keycloak#3…
47968bd 
…5616) (keycloak#35666)

closes: keycloak#35526

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit 4c7dea5)
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+2 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shawkins @jonkoops @vmuzikar
0