8000 Fixed dialog title when deleting a user by agagancarczyk · Pull Request #35499 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Fixed dialog title when deleting a user - #35499

Merged
agagancarczyk merged 3 commits into
keycloak:mainfrom
agagancarczyk:issue-35475
Dec 4, 2024
Merged

agagancarczyk merged 3 commits into
keycloak:mainfrom
agagancarczyk:issue-35475

Conversation

@agagancarczyk
Copy link
Copy Markdown
Contributor

Closes #35475

Signed-off-by: Agnieszka Gancarczyk <agagancarczyk@gmail.com>
@jonkoops jonkoops left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebastEnn
Copy link
Copy Markdown
Contributor

FYI https://www.i18next.com/translation-function/plurals

So we would need

deleteConfirmUser_one=Delete user?
deleteConfirmUser_other=Delete users?

in messages_en.properties.

This would break compatibility with other translations tho 🤔

@jonkoops
jonkoops commented Dec 3, 2024
Copy link
Copy Markdown
Contributor

This would break compatibility with other translations tho

Would it? This just means they need to be updated.

@SebastEnn
Copy link
Copy Markdown
Contributor

Would it? This just means they need to be updated.

Well, the key is deleteConfirmUsers and the value Delete user?.
Some languages might have set the value to something that would fit _other, and some other maybe for _one.

Either way, translations would need to be updated. So I guess we can ignore this and eventually someone will notice and fix the translation 🙂

@edewit
edewit commented Dec 4, 2024
Copy link
Copy Markdown
Contributor

@SebastEnn we add and update the translations constantly and we only maintain the English version, so broken translations can't be helped

Signed-off-by: Agnieszka Gancarczyk <agagancarczyk@gmail.com>
Signed-off-by: Agnieszka Gancarczyk <agagancarczyk@gmail.com>
@agagancarczyk
agagancarczyk merged commit 2e85dc5 into keycloak:main Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete user confirm title is wrong

4 participants

0