8000 Improve session polling to prevent accidental redirects (#35143) by jonkoops · Pull Request #35408 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Improve session polling to prevent accidental redirects (#35143) - #35408

Merged
mposolda merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-35143-26.0
Nov 28, 2024
Merged

Improve session polling to prevent accidental redirects (#35143)#35408
mposolda merged 1 commit into
keycloak:release/26.0from
jonkoops:backport-35143-26.0

Conversation

@jonkoops
@jonkoops jonkoops commented Nov 28, 2024
Copy link
Copy Markdown
Contributor

Closes #33071

Signed-off-by: Jon Koops jonkoops@gmail.com
(cherry picked from commit 687223f)

@jonkoops
Improve session polling to prevent accidental redirects
522d801 
Closes keycloak#33071

Signed-off-by: Jon Koops <jonkoops@gmail.com>
(cherry picked from commit 687223f)
@jonkoops
jonkoops requested review from a team as code owners November 28, 2024 11:48
@jonkoops jonkoops changed the title Improve session polling to prevent accidental redirects Improve session polling to prevent accidental redirects (#35143) Nov 28, 2024
@jonkoops jonkoops mentioned this pull request Nov 28, 2024
Merged
@mposolda mposolda self-assigned this Nov 28, 2024
@mposolda
mposolda enabled auto-merge (rebase) November 28, 2024 11:54
@mposolda
mposolda merged commit 7acb302 into keycloak:release/26.0 Nov 28, 2024
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Nov 28, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Nov 28, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.BrowserButtonsTest#appInitiatedRegistrationWithBackButton

Keycloak CI - Forms IT (chrome)

org.openqa.selenium.NoSuchElementException: 
no such element: Unable to locate element: {"method":"css selector","selector":"*[name='login']"}
  (Session info: chrome=131.0.6778.85)
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Build info: version: '4.21.0', revision: '79ed462ef4'
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithRememberMe(LoginTest.java:633)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginWithEmailUserAndRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.forms.LoginTest.loginWithEmailUserAndRememberMe(LoginTest.java:740)
...

Report flaky test

@jonkoops
jonkoops deleted the backport-35143-26.0 branch November 28, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonkoops @mposolda
0