8000 fix: upgrading angus mail to 2.0.3 by shawkins · Pull Request #34316 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix: upgrading angus mail to 2.0.3 - #34316

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss33798
Oct 25, 2024
Merged

fix: upgrading angus mail to 2.0.3#34316
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss33798

Conversation

@shawkins
@shawkins shawkins commented Oct 24, 2024
Copy link
Copy Markdown
Contributor

closes: #33798

@shawkins
fix: upgrading angus mail to 2.0.3
b93b410 
closes: keycloak#33798

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
8000
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 24, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 24, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

org.keycloak.testsuite.federation.ldap.LDAPUserLoginTest#loginLDAPUserAuthenticationNoneEncryptionSSL

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: expected:<Invalid username or password.> but was:<null>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at org.junit.Assert.assertEquals(Assert.java:146)
...

Report flaky test

@shawkins
shawkins marked this pull request as ready for review October 25, 2024 12:23
@shawkins
shawkins requested a review from a team as a code owner October 25, 2024 12:23
vmuzikar
vmuzikar approved these changes Oct 25, 2024
View reviewed changes
@vmuzikar vmuzikar left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like we should be also good on the productization side.

@shawkins Can you please create a backport?

@vmuzikar
vmuzikar merged commit dbc2ab3 into keycloak:main Oct 25, 2024
shawkins added a commit to shawkins/keycloak that referenced this pull request Oct 28, 2024
@shawkins
fix: upgrading angus mail to 2.0.3 (keycloak#34316)
df89185 
closes: keycloak#33798

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit dbc2ab3)
@shawkins
shawkins commented Oct 28, 2024
Copy link
Copy Markdown
Contributor Author

LGTM. Looks like we should be also good on the productization side.

@shawkins Can you please create a backport?

#34392

stianst pushed a commit that referenced this pull request Oct 29, 2024
@shawkins
fix: upgrading angus mail to 2.0.3 (#34316) (#34392)
1b9bf5d 
closes: #33798

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
(cherry picked from commit dbc2ab3)
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test
4C89

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CVE-2021-44549 - org.eclipse.angus/angus-mail: Enabling Secure Server Identity Checks for Safer SMTPS Communication

2 participants

@shawkins @vmuzikar
0