8000 ConcurrentModificationException when restarting user sessions by ahus1 · Pull Request #34314 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

ConcurrentModificationException when restarting user sessions - #34314

Merged
stianst merged 1 commit into
keycloak:release/26.0from
ahus1:is-34093-backport
Oct 28, 2024
Merged

ConcurrentModificationException when restarting user sessions#34314
stianst merged 1 commit into
keycloak:release/26.0from
ahus1:is-34093-backport

Conversation

@ahus1
@ahus1 ahus1 commented Oct 24, 2024
Copy link
Copy Markdown
Member

Closes #34093

@martin-kanis @ahus1
ConcurrentModificationException when restarting user sessions
b91e9e2 8000 
Closes keycloak#34093

Signed-off-by: Martin Kanis <mkanis@redhat.com>
@ahus1 ahus1 self-assigned this Oct 24, 2024
@ahus1 ahus1 mentioned this pull request Oct 24, 2024
Closed
1 of 2 tasks
@keycloak-github-bot
keycloak-github-bot Bot commented Oct 24, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#testPostBrokerLoginFlowWithOTP_bruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

java.lang.AssertionError: User should be disabled by brute force.
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.broker.AbstractAdvancedBrokerTest.testPostBrokerLoginFlowWithOTP_bruteForceEnabled(AbstractAdvancedBrokerTest.java:580)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...

Report flaky test

org.keycloak.testsuite.forms.LoginTest#loginAgainWithoutRememberMe

Keycloak CI - Forms IT (chrome)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertFalse(Assert.java:65)
	at org.junit.Assert.assertFalse(Assert.java:75)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 24, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ahus1
ahus1 marked this pull request as ready for review October 24, 2024 20:26
@ahus1
ahus1 requested review from a team as code owners October 24, 2024 20:26
@stianst
stianst merged commit a6d7e91 into keycloak:release/26.0 Oct 28, 2024
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst stianst approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@ahus1 ahus1

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahus1 @stianst @martin-kanis
0