8000 Remove not needed Quarkus dependencies related to Dev UI services by vmuzikar · Pull Request #34309 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Remove not needed Quarkus dependencies related to Dev UI services - #34309

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
vmuzikar:remove-deps
Oct 30, 2024
Merged

Remove not needed Quarkus dependencies related to Dev UI services#34309
vmuzikar merged 1 commit into
keycloak:mainfrom
vmuzikar:remove-deps

Conversation

@vmuzikar
@vmuzikar vmuzikar commented Oct 24, 2024
Copy link
Copy Markdown
Contributor

Closes #34308

@vmuzikar
vmuzikar marked this pull request as ready for review October 30, 2024 17:03
@vmuzikar
vmuzikar requested review from a team as code owners October 30, 2024 17:03
shawkins
shawkins approved these changes Oct 30, 2024
View reviewed changes
@shawkins shawkins left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmuzikar
Remove not needed Quarkus dependencies related to Dev UI services
c1922e2 
Closes keycloak#34308

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
@vmuzikar
vmuzikar enabled auto-merge (squash) October 30, 2024 17:14
ahus1
ahus1 approved these changes Oct 30, 2024
View reviewed changes
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Oct 30, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Oct 30, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.actions.TermsAndConditionsTest#termsDeclined

Keycloak CI - Base IT (1)

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.keycloak.testsuite.actions.TermsAndConditionsTest.termsDeclined(TermsAndConditionsTest.java:170)
...

Report flaky test

@vmuzikar
vmuzikar merged commit abb7c41 into keycloak:main Oct 30, 2024
vmuzikar added a commit to vmuzikar/keycloak that referenced this pull request Oct 31, 2024
@vmuzikar
Remove not needed Quarkus dependencies related to Dev UI services (ke…
7b8b840 
…ycloak#34309)

Closes keycloak#34308

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
(cherry picked from commit abb7c41)
mabartos pushed a commit that referenced this pull request Oct 31, 2024
@vmuzikar
Remove not needed Quarkus dependencies related to Dev UI services (#3…
f59aae2 
…4309) (#34534)

Closes #34308

Signed-off-by: Václav Muzikář <vmuzikar@redhat.com>
(cherry picked from commit abb7c41)
@vmuzikar vmuzikar mentioned this pull request Oct 31, 2024
Closed
2 tasks done
@edewit edewit mentioned this pull request Nov 19, 2024
Closed
@edewit edewit mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shawkins shawkins shawkins approved these changes
@ahus1 ahus1 ahus1 approved these changes
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove not needed Quarkus dependencies related to Dev UI services

3 participants

@vmuzikar @shawkins @ahus1
0